Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Yao Qi <yao@codesourcery.com>,
	       "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [patch] Re: "optimized out" on gdb.base/gdb1090.exp
Date: Tue, 12 Apr 2011 21:22:00 -0000	[thread overview]
Message-ID: <4DA4C26C.8010304@linux.vnet.ibm.com> (raw)
In-Reply-To: <20110412160220.GA18580@host1.jankratochvil.net>

Thanks Jan for reviewing this. This is the updated patch with the suggested modifications.

Checking out the original PR 1090 that originated this testcase, it doesn't mention any particularity regarding frame or backtrace, which leads me to believe that changing where 'print' is called should not affect the main focus of the testcase.

Thanks,
-- 
Edjunior

2011-04-12  Edjunior Machado  <emachado@br.ibm.com>

	* testsuite/gdb.base/gdb1090.exp: change breakpoint location to	read the
	content of 's24' correctly (avoiding "optimized out").
	* testsuite/gdb.base/gdb1090.c: add comment in order to set breakpoint.

diff --git a/gdb/testsuite/gdb.base/gdb1090.c b/gdb/testsuite/gdb.base/gdb1090.c
index 22f2cec..8933952 100644
--- a/gdb/testsuite/gdb.base/gdb1090.c
+++ b/gdb/testsuite/gdb.base/gdb1090.c
@@ -36,7 +36,7 @@ void foo ()
    register struct s_2_by_4 s24;
    s24.field_0 = 1170;
    s24.field_1 = 64701;
-  marker (s24);
+  marker (s24); /* break-here */
    return;
  }
  
diff --git a/gdb/testsuite/gdb.base/gdb1090.exp b/gdb/testsuite/gdb.base/gdb1090.exp
index a15fd04..ab568ab 100644
--- a/gdb/testsuite/gdb.base/gdb1090.exp
+++ b/gdb/testsuite/gdb.base/gdb1090.exp
@@ -40,11 +40,13 @@ gdb_start
  gdb_reinitialize_dir $srcdir/$subdir
  gdb_load ${binfile}
  
-if ![runto marker] then {
-    perror "couldn't run to breakpoint"
-    continue
-}
-gdb_test "up" ".*foo.*" "up from marker"
+if ![runto_main] then {
+    fail "Can't run to main"
+    return 1
+}
+
+gdb_breakpoint [gdb_get_line_number "break-here"]
+gdb_continue_to_breakpoint "break-here" ".* break-here .*"
  
  gdb_test_multiple "print s24" "print s24" {
      -re "\\\$\[0-9\]* = \\{field_0 = 1170, field_1 = 64701\\}\r\n$gdb_prompt $" {


       reply	other threads:[~2011-04-12 21:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4DA3A7D0.2000701@linux.vnet.ibm.com>
     [not found] ` <4DA3B701.3060902@codesourcery.com>
     [not found]   ` <4DA4573D.1040101@linux.vnet.ibm.com>
     [not found]     ` <20110412160220.GA18580@host1.jankratochvil.net>
2011-04-12 21:22       ` Edjunior Barbosa Machado [this message]
2011-04-13  1:26         ` Yao Qi
2011-04-13 11:15         ` Jan Kratochvil
2011-04-13 21:20           ` Edjunior Barbosa Machado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DA4C26C.8010304@linux.vnet.ibm.com \
    --to=emachado@linux.vnet.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox