From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13072 invoked by alias); 7 Apr 2011 04:19:04 -0000 Received: (qmail 13057 invoked by uid 22791); 7 Apr 2011 04:19:02 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 07 Apr 2011 04:18:57 +0000 Received: (qmail 1387 invoked from network); 7 Apr 2011 04:18:57 -0000 Received: from unknown (HELO ?192.168.0.102?) (yao@127.0.0.2) by mail.codesourcery.com with ESMTPA; 7 Apr 2011 04:18:57 -0000 Message-ID: <4D9D3B2A.1050302@codesourcery.com> Date: Thu, 07 Apr 2011 04:19:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.14) Gecko/20110223 Lightning/1.0b2 Thunderbird/3.1.8 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [try 2nd 3/8] Refactor copy_svc_os References: <201104062055.p36KtdDi009302@d06av02.portsmouth.uk.ibm.com> In-Reply-To: <201104062055.p36KtdDi009302@d06av02.portsmouth.uk.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00105.txt.bz2 On 04/07/2011 04:55 AM, Ulrich Weigand wrote: > Yao Qi wrote: > >> 2011-03-24 Yao Qi >> >> * gdb/arm-linux-tdep.c (arm_linux_copy_svc): Remove parameters INSN >> and TO. >> * gdb/arm-tdep.c (cleanup_svc): Handle variable instruction size. >> (arm_copy_svc): Remove parameters INSN and TO. >> (decode_svc_copro): Update caller. >> * gdb/arm-tdep.h (struct displaced_step_closure): Remove parameters >> from function pointer `copy_svc_os'. > > This looks OK to me. > Thanks for the review. Applied to trunk. http://sourceware.org/ml/gdb-cvs/2011-04/msg00047.html -- Yao (齐尧)