From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id AHtxCXOKbl+0MAAAWB0awg (envelope-from ) for ; Fri, 25 Sep 2020 20:25:23 -0400 Received: by simark.ca (Postfix, from userid 112) id 246591EF4B; Fri, 25 Sep 2020 20:25:23 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C6BBF1E790 for ; Fri, 25 Sep 2020 20:25:22 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2F4F5388A438; Sat, 26 Sep 2020 00:25:22 +0000 (GMT) Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) by sourceware.org (Postfix) with ESMTPS id 257103857828 for ; Sat, 26 Sep 2020 00:25:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 257103857828 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=saagarjha.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=saagarjha28@gmail.com Received: by mail-pj1-f65.google.com with SMTP id v14so302823pjd.4 for ; Fri, 25 Sep 2020 17:25:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=MguQR3P2zcZbzGsDb7prPbscNKkIcjT5ckMQdv76GA4=; b=ZydRBDo1/Cup9fSx5Y45uazAfk1M/7OKpdyxr5JYig3zDzhGg06igccmYHbx6i858M S7zZ81tS5JV/KibBCuujDAlKMLte8X5o5NEsclnNQhOXjcMcS6/4Xn4jB25KbT1Fws8I fFcsll4Bk1qNBRDOPSAP4+cumZPHDeyGIMMIG+yk3usLcJkWmLbN9iCnSyvZ7SfnOaXd g13TYTKhcg/tDIFq0tC7/tl4pzdSbizz7/Q+U7Xqt/5Rrb+rkXvSiFSs3NrWUZ/ZnSB5 eE20IX6fI1XRF4h4bzZjdnXDn/fIRk+DeWilYmqc/TXxOV7hSNWlpgQOZGb50aIVTCCD JnHQ== X-Gm-Message-State: AOAM531alTTugUmy6tQdGJnHR9Q4erxfRHys6lEgyxSJTpSQK7FCRK2Y 5NT7EzIq0w7st3UEj+KGzZdM1oDQEHQ= X-Google-Smtp-Source: ABdhPJxP1Q1Blk5cBrFLQQ6O2ua5zPgIxEsHhGCO6UFTahvDUk6Bp9UFc45YcHsEpsQ/9RYi4HRmeQ== X-Received: by 2002:a17:902:ac82:b029:d1:e5fa:79e1 with SMTP id h2-20020a170902ac82b02900d1e5fa79e1mr1887122plr.68.1601079919289; Fri, 25 Sep 2020 17:25:19 -0700 (PDT) Received: from localhost.localdomain (c-73-92-124-25.hsd1.ca.comcast.net. [73.92.124.25]) by smtp.gmail.com with ESMTPSA id d6sm287160pjw.0.2020.09.25.17.25.18 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Sep 2020 17:25:18 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.0.3.2.33\)) Subject: Re: [PATCH] Add a missing munmap_list move constructor From: Saagar Jha In-Reply-To: Date: Fri, 25 Sep 2020 17:25:17 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <4D96229E-2964-4C3E-A5E4-79C7A50FDAAD@saagarjha.com> References: <883A80DB-0918-4BA6-B387-A54581BFEA42@saagarjha.com> <20200925070525.47993-1-saagar@saagarjha.com> To: Simon Marchi X-Mailer: Apple Mail (2.3654.0.3.2.33) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Thanks, the code seems to build cleanly now :) > On Sep 25, 2020, at 07:58, Simon Marchi wrote: >=20 > On 2020-09-25 3:05 a.m., Saagar Jha wrote: >> compile_module attempts to request a move constructor, but because >> munmap_list doesn't have one it gets implicitly deleted. This is an >> warning on clang under -Wdefaulted-function-deleted (which is enabled = by >> default): >>=20 >> In file included from compile/compile-object-load.c:21: >> compile/compile-object-load.h:56:3: error: explicitly defaulted move = constructor is implicitly deleted [-Werror,-Wdefaulted-function-deleted] >> compile_module (compile_module &&other) =3D default; >> ^ >> compile/compile-object-load.h:86:22: note: move constructor of = 'compile_module' is implicitly deleted because field 'munmap_list' has a = deleted move constructor >> struct munmap_list munmap_list; >> ^ >> compile/compile-object-load.h:30:28: note: 'munmap_list' has been = explicitly marked deleted here >> DISABLE_COPY_AND_ASSIGN (munmap_list); >> ^ >>=20 >> gdb/ChangeLog: >>=20 >> * compile/compile-object-load.h: Give munmap_list a move >> constructor. >=20 > Thanks, I pushed it. FYI, I tweaked the ChangeLog entry to include = the > structure name in parenthesis: >=20 > * compile/compile-object-load.h (struct munmap_list): Add > explicitly-defined move constructor. >=20 > Simon