From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30515 invoked by alias); 29 Mar 2011 05:02:14 -0000 Received: (qmail 30500 invoked by uid 22791); 29 Mar 2011 05:02:13 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,TW_DB,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 29 Mar 2011 05:02:09 +0000 Received: (qmail 20190 invoked from network); 29 Mar 2011 05:02:08 -0000 Received: from unknown (HELO ?192.168.0.102?) (yao@127.0.0.2) by mail.codesourcery.com with ESMTPA; 29 Mar 2011 05:02:08 -0000 Message-ID: <4D9167CD.4070205@codesourcery.com> Date: Tue, 29 Mar 2011 07:54:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.14) Gecko/20110223 Lightning/1.0b2 Thunderbird/3.1.8 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [try 2nd, patch] Move common macros to i386-dbg-reg.h References: <4D57AB12.1050708@codesourcery.com> <4D79AD80.5050803@codesourcery.com> In-Reply-To: <4D79AD80.5050803@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg01159.txt.bz2 On 03/11/2011 01:05 PM, Yao Qi wrote: > Compared with last version, two changes are in this new patch, > 1) rename i386-common.h to i386-dbg-reg.h, > 2) add dependency tracking in gdbserver. > > OK for mainline after 7.3 branch is created? > > gdb/ > > * i386-nat.h: Include i386-dbg-reg.h. > Move macros to i386-dbg-reg.h. > * i386-nat.c: Move macros and structs to i386-dbg-reg.h. > New variable struct i386_debug_reg_state state to replace > other variables dr_mirror, dr_ref_count, dr_control_mirror, > and dr_status_mirror. > (i386_insert_aligned_watchpoint): Add one formal parameter > struct i386_debug_reg_state *STATE. > Update code using these variables. > (i386_remove_aligned_watchpoint, i386_show_dr): Likewise. > (i386_cleanup_dregs): Likewise. > (i386_handle_nonaligned_watchpoint): Likewise. > * common/i386-dbg-reg.h: New. Common macros and structs. > > gdb/gdbserver/ > > * i386-low.h: Include i386-dbg-reg.h. > Move macros to i386-dbg-reg.h. > * i386-low.c (i386_set_debug_register_length): New. > (i386_low_init_dregs): Call i386_set_debug_register_length. > * Makefile.in (i386_low_h) Depends on i386-dbg-reg.h. Ping. -- Yao (齐尧)