From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4281 invoked by alias); 11 Mar 2011 18:36:20 -0000 Received: (qmail 4142 invoked by uid 22791); 11 Mar 2011 18:36:20 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mailgw.tensilica.com (HELO mailgw.tensilica.com) (65.119.96.134) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Mar 2011 18:36:16 +0000 Received: from localhost (unknown [127.0.0.1]) by mailgw.tensilica.com (Postfix) with ESMTP id 80E8811606DE; Fri, 11 Mar 2011 18:36:14 +0000 (UTC) Received: from mailgw.tensilica.com ([127.0.0.1]) by localhost (mailgw.tensilica.com [127.0.0.1]) (amavisd-maia, port 10024) with ESMTP id 16737-04; Fri, 11 Mar 2011 10:36:14 -0800 (PST) Received: from mail.tensilica.com (mail.tensilica.com [192.168.15.138]) by mailgw.tensilica.com (Postfix) with ESMTP id 173A511606DC; Fri, 11 Mar 2011 10:36:14 -0800 (PST) Received: from [192.168.11.68] (192.168.11.68) by mail.tensilica.com (192.168.15.138) with Microsoft SMTP Server id 8.2.254.0; Fri, 11 Mar 2011 10:36:14 -0800 Message-ID: <4D7A6B9D.90408@tensilica.com> Date: Fri, 11 Mar 2011 21:04:00 -0000 From: Maxim Grigoriev User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.10 MIME-Version: 1.0 To: Joel Brobecker CC: "gdb-patches@sourceware.org" Subject: [commit] Correct style issues in xtensa-tdep.c References: <4D798969.8070309@tensilica.com> <20110311064501.GA30306@adacore.com> In-Reply-To: <20110311064501.GA30306@adacore.com> Content-Type: multipart/mixed; boundary="------------080808030503020901010000" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00671.txt.bz2 --------------080808030503020901010000 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Content-length: 918 I am surprised I missed it. Thanks for noticing this. This patch corrects the style violation mentioned by Joel. On 03/10/2011 10:45 PM, Joel Brobecker wrote: >> 2011-03-10 Maxim Grigoriev >> >> * xtensa-tdep.c (windowing_enabled): Remove inline attribute. >> (xtensa_write_register, xtensa_read_register): Likewise. >> (xtensa_hextochar): Removed. >> (xtensa_init_reggroups): Replace xtensa_hextochar () by explicit code. >> > Small comments, seen while scanning your patch... > > >> -static inline void warning_once () >> +static void warning_once () >> > The function name should be on the first column of the line. > This is to facilitate the search of the function implementation > (we can use:<> for instance). Also, > functions with no arguments should be declared with a "void" > parameter. Thus: > > static void > warning_once (void) > > --------------080808030503020901010000 Content-Type: text/plain; name="Style.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="Style.diff" Content-length: 686 2011-03-11 Maxim Grigoriev * xtensa-tdep.c (warning_once): Correct style issues. Index: gdb/xtensa-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/xtensa-tdep.c,v retrieving revision 1.54 diff -u -r1.54 xtensa-tdep.c --- gdb/xtensa-tdep.c 11 Mar 2011 02:32:31 -0000 1.54 +++ gdb/xtensa-tdep.c 11 Mar 2011 18:25:19 -0000 @@ -1421,7 +1421,8 @@ /* Report a problem with prologue analysis while doing backtracing. But, do it only once to avoid annoyng repeated messages. */ -static void warning_once () +static void +warning_once (void) { if (xtensa_session_once_reported == 0) warning (_("\ --------------080808030503020901010000--