I am surprised I missed it. Thanks for noticing this. This patch corrects the style violation mentioned by Joel. On 03/10/2011 10:45 PM, Joel Brobecker wrote: >> 2011-03-10 Maxim Grigoriev >> >> * xtensa-tdep.c (windowing_enabled): Remove inline attribute. >> (xtensa_write_register, xtensa_read_register): Likewise. >> (xtensa_hextochar): Removed. >> (xtensa_init_reggroups): Replace xtensa_hextochar () by explicit code. >> > Small comments, seen while scanning your patch... > > >> -static inline void warning_once () >> +static void warning_once () >> > The function name should be on the first column of the line. > This is to facilitate the search of the function implementation > (we can use:<> for instance). Also, > functions with no arguments should be declared with a "void" > parameter. Thus: > > static void > warning_once (void) > >