From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13885 invoked by alias); 9 Mar 2011 19:11:29 -0000 Received: (qmail 13877 invoked by uid 22791); 9 Mar 2011 19:11:28 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SHORT_BODY,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 09 Mar 2011 19:11:23 +0000 Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id DADAA1500D; Wed, 9 Mar 2011 11:11:21 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost2.vmware.com (Postfix) with ESMTP id CD8F28F097; Wed, 9 Mar 2011 11:11:21 -0800 (PST) Message-ID: <4D77D0D9.8030202@vmware.com> Date: Wed, 09 Mar 2011 20:18:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: "gdb-patches@sourceware.org" , Vladimir Prus Subject: [RFA] mi-cmd-disas.c (mi_cmd_disassemble): Fix memory leak. Content-Type: multipart/mixed; boundary="------------030903040300040508010200" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00620.txt.bz2 This is a multi-part message in MIME format. --------------030903040300040508010200 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 5 OK? --------------030903040300040508010200 Content-Type: text/plain; name="mi-cmd-disas.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="mi-cmd-disas.txt" Content-length: 1040 2011-03-09 Michael Snyder * mi-cmd-disas.c (mi_cmd_disassemble): Fix memory leak. Index: mi-cmd-disas.c =================================================================== RCS file: /cvs/src/src/gdb/mi/mi-cmd-disas.c,v retrieving revision 1.38 diff -u -p -r1.38 mi-cmd-disas.c --- mi-cmd-disas.c 12 Jan 2011 21:09:39 -0000 1.38 +++ mi-cmd-disas.c 9 Mar 2011 19:08:54 -0000 @@ -73,6 +73,7 @@ mi_cmd_disassemble (char *command, char int how_many = -1; CORE_ADDR low = 0; CORE_ADDR high = 0; + struct cleanup *cleanups = make_cleanup (null_cleanup, NULL); /* Options processing stuff. */ int optind = 0; @@ -103,6 +104,7 @@ mi_cmd_disassemble (char *command, char case FILE_OPT: file_string = xstrdup (optarg); file_seen = 1; + make_cleanup (xfree, file_string); break; case LINE_OPT: line_num = atoi (optarg); @@ -169,4 +171,6 @@ mi_cmd_disassemble (char *command, char file_string, disasm_flags, how_many, low, high); + + do_cleanups (cleanups); } --------------030903040300040508010200--