From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31656 invoked by alias); 9 Mar 2011 18:15:37 -0000 Received: (qmail 31631 invoked by uid 22791); 9 Mar 2011 18:15:37 -0000 X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mailgw.tensilica.com (HELO mailgw.tensilica.com) (65.119.96.134) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 09 Mar 2011 18:15:32 +0000 Received: from localhost (unknown [127.0.0.1]) by mailgw.tensilica.com (Postfix) with ESMTP id 76238116059B; Wed, 9 Mar 2011 18:15:31 +0000 (UTC) Received: from mailgw.tensilica.com ([127.0.0.1]) by localhost (mailgw.tensilica.com [127.0.0.1]) (amavisd-maia, port 10024) with ESMTP id 16095-01; Wed, 9 Mar 2011 10:15:31 -0800 (PST) Received: from mail.tensilica.com (mail.tensilica.com [192.168.15.138]) by mailgw.tensilica.com (Postfix) with ESMTP id E8EC91160598; Wed, 9 Mar 2011 10:15:14 -0800 (PST) Received: from [192.168.11.68] (192.168.11.68) by mail.tensilica.com (192.168.15.138) with Microsoft SMTP Server id 8.2.254.0; Wed, 9 Mar 2011 10:15:14 -0800 Message-ID: <4D77C3B2.5050106@tensilica.com> Date: Wed, 09 Mar 2011 18:38:00 -0000 From: Maxim Grigoriev User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.10 MIME-Version: 1.0 To: Joel Brobecker CC: "gdb-patches@sourceware.org" Subject: Re: [commit] Fix Xtensa-specific bug in MI command References: <4D76EC10.3000008@tensilica.com> <20110309035117.GR30306@adacore.com> In-Reply-To: <20110309035117.GR30306@adacore.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00615.txt.bz2 On 03/08/2011 07:51 PM, Joel Brobecker wrote: >> Fix Xtensa-specific bug in MI command -data-list-changed-registers. >> > A small request: If you could give more details with your patches > about what you are fixing. For the previous ones, there wasn't > much to add, just extending support for new features. But for this > one, it would have been helpful to know what type of bug it was. > For instance, a transcript showing the issue can be useful to > other people hitting the problem, and doing an internet search. > > Eclipse CDT uses this MI command to get a list of changed registers compared to the previous register file state saved before. It happens, when Eclipse user opens a register display window. After each new event in the debugging session, such as "step", "next" ( which lead to executing some instruction(s) on the target ), updated registers are high-lighted in that display window. MI command -data-list-changed-registers uses generic hook gdbarch_register_reggroup_p () to analyse updates to the register file. Registers from standard GDB group "save_reggroup" have to be always a part of this analysis. It's been missing on Xtensa. That's why changed registers did not always display properly in the Eclipse register display window. Thanks for your notes and suggestions, -- Maxim Grigoriev Tensilica, Inc. Santa Clara, CA 408-566-1770