From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23934 invoked by alias); 8 Mar 2011 01:11:55 -0000 Received: (qmail 23925 invoked by uid 22791); 8 Mar 2011 01:11:54 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 Mar 2011 01:11:50 +0000 Received: (qmail 8141 invoked from network); 8 Mar 2011 01:11:47 -0000 Received: from unknown (HELO ?192.168.0.102?) (yao@127.0.0.2) by mail.codesourcery.com with ESMTPA; 8 Mar 2011 01:11:47 -0000 Message-ID: <4D75824C.1090806@codesourcery.com> Date: Tue, 08 Mar 2011 04:33:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101208 Lightning/1.0b2 Thunderbird/3.1.7 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [patch, arm] Use cached dsc->is_thumb instead of re-computing References: <201103071604.p27G4M7r031413@d06av02.portsmouth.uk.ibm.com> In-Reply-To: <201103071604.p27G4M7r031413@d06av02.portsmouth.uk.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00511.txt.bz2 On 03/08/2011 12:04 AM, Ulrich Weigand wrote: > >> * arm-tdep.c: Remove prototype declaration displaced_in_arm_mode. >> (displaced_read_reg): Add `dsc' parameter, remove `from' parameter. >> Use cached result instead of calling displaced_in_arm_mode again. >> (branch_write_pc, alu_write_pc, load_write_pc): Add `dsc' parameter. >> (displaced_write_reg, copy_preload, copy_preload_reg): Callers update. >> (cleanup_copro_load_store, copy_copro_load_store): Likewise. >> (cleanup_branch, copy_bx_blx_reg, copy_alu_imm): Likewise. >> (cleanup_alu_reg, copy_alu_reg, cleanup_alu_shifted_reg): Likewise. >> (copy_alu_shifted_reg, cleanup_load, cleanup_store): Likewise. >> (copy_extra_ld_st, copy_ldr_str_ldrb_strb): Likewise. >> (cleanup_block_load_all, cleanup_block_store_pc): Likewise. >> (cleanup_block_load_pc, copy_block_xfer): Likewise. >> * arm-linux-tdep.c (arm_linux_copy_svc): Callers update. >> (arm_catch_kernel_helper_return): Likewise. >> * gdb/arm-tdep.h : Update function declarations. > > This is OK. Thanks. Applied. http://sourceware.org/ml/gdb-cvs/2011-03/msg00111.html -- Yao (齐尧)