From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25702 invoked by alias); 7 Mar 2011 02:20:12 -0000 Received: (qmail 25690 invoked by uid 22791); 7 Mar 2011 02:20:10 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Mar 2011 02:19:28 +0000 Received: (qmail 4292 invoked from network); 7 Mar 2011 02:19:26 -0000 Received: from unknown (HELO ?192.168.0.102?) (yao@127.0.0.2) by mail.codesourcery.com with ESMTPA; 7 Mar 2011 02:19:26 -0000 Message-ID: <4D7440AA.5060106@codesourcery.com> Date: Mon, 07 Mar 2011 04:28:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101208 Lightning/1.0b2 Thunderbird/3.1.7 MIME-Version: 1.0 To: Jan Kratochvil CC: Andreas Schwab , Mark Kettenis , brobecker@adacore.com, tromey@redhat.com, gdb-patches@sourceware.org Subject: Re: [patch] Fix Solaris make gdb/data-directory/ compat. [Re: [rfa/rfc] Build libcommon.a for gdb and gdbserver] References: <4D34C9DE.3040603@codesourcery.com> <4D375F44.70504@codesourcery.com> <20110219121448.GA17297@adacore.com> <201102191318.p1JDIQE6005275@glazunov.sibelius.xs4all.nl> <20110306161631.GA15735@host1.jankratochvil.net> <201103061658.p26Gwvni017860@glazunov.sibelius.xs4all.nl> <20110306190515.GC22789@host1.jankratochvil.net> In-Reply-To: <20110306190515.GC22789@host1.jankratochvil.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00413.txt.bz2 On 03/07/2011 03:05 AM, Jan Kratochvil wrote: > On Sun, 06 Mar 2011 18:23:00 +0100, Andreas Schwab wrote: >> The problem here is that $(PYTHON_FILES) appears as prerequisite of the >> rule and the files are found via VPATH, so Solaris make modified the >> expansion of $(PYTHON_FILES) to prefix it with the VPATH, causing >> PYTHON_SRCDIR to appear twice. (*Note (autoconf) Automatic Rule Rewriting::) > * Automatic Rule Rewriting:: `VPATH' goes wild on Solaris > > Thanks for the explanatory documentation reference. > > Fixed it on OpenSolaris with /usr/bin/make and checked it is still compatible > with GNU/Linux. Checked both the in-tree and out-of-tree compilation and > installation. Checked out-of-tree build directory in a different number of > subdirectories than the srcdir. > > I will even check it in with no comments in some time but a review would be > better. Jan, I don't have some comments to this patch. Do you know which commit breaks build on Solaris? If it is related to my recent libcommon.a patches, I'd like to help on this problem. -- Yao (齐尧)