From: Michael Snyder <msnyder@vmware.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Mark Kettenis <mark.kettenis@xs4all.nl>
Subject: Re: [RFA] i386-tdep.c, check target_read_memory for error.
Date: Sun, 06 Mar 2011 18:48:00 -0000 [thread overview]
Message-ID: <4D73D59A.2040908@vmware.com> (raw)
In-Reply-To: <20110306141515.GA1895@host1.jankratochvil.net>
Jan Kratochvil wrote:
> On Fri, 04 Mar 2011 22:37:52 +0100, Michael Snyder wrote:
>> Call error if target_read_memory fails.
> [...]
>> - target_read_memory (pc, &op, 1);
>> + if (target_read_memory (pc, &op, 1))
>> + error (_("Couldn't read memory at pc (%s)"),
>> + paddress (gdbarch, pc));
>
> There is the function `read_memory' for such purpose.
I don't understand the objection. target_read_memory may fail and
return an error code. Coverity reports that the return value is checked
in 78 out of 97 calling instances. So what's wrong with checking it now?
next prev parent reply other threads:[~2011-03-06 18:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 21:38 Michael Snyder
2011-03-06 14:56 ` Jan Kratochvil
2011-03-06 17:00 ` Mark Kettenis
2011-03-06 22:34 ` Michael Snyder
2011-03-08 2:35 ` Mark Kettenis
2011-03-08 18:47 ` Michael Snyder
2011-03-08 18:59 ` Mark Kettenis
2011-03-08 19:27 ` Pedro Alves
2011-03-08 19:41 ` Mark Kettenis
2011-03-08 19:50 ` Pedro Alves
2011-03-09 1:32 ` Michael Snyder
2011-03-06 18:48 ` Michael Snyder [this message]
2011-03-06 19:00 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D73D59A.2040908@vmware.com \
--to=msnyder@vmware.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox