From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18540 invoked by alias); 5 Mar 2011 20:35:23 -0000 Received: (qmail 18359 invoked by uid 22791); 5 Mar 2011 20:35:23 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SHORT_BODY,TW_BJ,TW_YM,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 05 Mar 2011 20:35:17 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id A2EB913404 for ; Sat, 5 Mar 2011 12:35:16 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost3.vmware.com (Postfix) with ESMTP id 99A21CD960 for ; Sat, 5 Mar 2011 12:35:16 -0800 (PST) Message-ID: <4D729E84.3050401@vmware.com> Date: Sat, 05 Mar 2011 20:35:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: "gdb-patches@sourceware.org" Subject: [RFA] elfread.c (elf_symtab_read): Stop memory leak. Content-Type: multipart/mixed; boundary="------------020608010301050602080706" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00372.txt.bz2 This is a multi-part message in MIME format. --------------020608010301050602080706 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 5 OK? --------------020608010301050602080706 Content-Type: text/plain; name="elfread.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="elfread.txt" Content-length: 1123 2011-03-05 Michael Snyder * elfread.c (elf_symtab_read): Stop memory leak. Index: elfread.c =================================================================== RCS file: /cvs/src/src/gdb/elfread.c,v retrieving revision 1.103 diff -u -p -r1.103 elfread.c --- elfread.c 7 Jan 2011 19:36:16 -0000 1.103 +++ elfread.c 5 Mar 2011 20:33:20 -0000 @@ -242,6 +242,7 @@ elf_symtab_read (struct objfile *objfile char *filesymname = ""; struct dbx_symfile_info *dbx = objfile->deprecated_sym_stab_info; int stripped = (bfd_get_symcount (objfile->obfd) == 0); + struct cleanup *back_to = make_cleanup (null_cleanup, NULL); for (i = 0; i < number_of_symbols; i++) { @@ -464,6 +465,7 @@ elf_symtab_read (struct objfile *objfile * max_index)); sectinfo = (struct stab_section_info *) xmalloc (size); + make_cleanup (xfree, sectinfo); memset (sectinfo, 0, size); sectinfo->num_sections = max_index; if (filesym == NULL) @@ -572,6 +574,7 @@ elf_symtab_read (struct objfile *objfile } } } + do_cleanups (back_to); } struct build_id --------------020608010301050602080706--