From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6751 invoked by alias); 5 Mar 2011 00:12:03 -0000 Received: (qmail 6740 invoked by uid 22791); 5 Mar 2011 00:12:00 -0000 X-SWARE-Spam-Status: No, hits=-4.4 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,RCVD_IN_DNSWL_HI,TW_DL,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 05 Mar 2011 00:11:56 +0000 Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id EC0122301D; Fri, 4 Mar 2011 16:11:54 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost2.vmware.com (Postfix) with ESMTP id DD4C38ED8E; Fri, 4 Mar 2011 16:11:54 -0800 (PST) Message-ID: <4D717FCA.7020603@vmware.com> Date: Sat, 05 Mar 2011 00:12:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: Pedro Alves CC: "gdb-patches@sourceware.org" Subject: Re: [RFA] dwarf2loc.c, loclist_read_variable, Assert frame not null References: <4D7169A9.4000207@vmware.com> <201103050000.54438.pedro@codesourcery.com> In-Reply-To: <201103050000.54438.pedro@codesourcery.com> Content-Type: multipart/mixed; boundary="------------040601060909040103060301" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00348.txt.bz2 This is a multi-part message in MIME format. --------------040601060909040103060301 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Content-length: 206 Pedro Alves wrote: > On Friday 04 March 2011 22:37:29, Michael Snyder wrote: >> + gdb_asert (frame); > > Please make sure patches compile before posting them. > My bad. Corrected patch attached. --------------040601060909040103060301 Content-Type: text/plain; name="null5.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="null5.txt" Content-length: 791 2011-03-04 Michael Snyder * dwarf2loc.c (loclist_read_variable): Assert frame not null. Index: dwarf2loc.c =================================================================== RCS file: /cvs/src/src/gdb/dwarf2loc.c,v retrieving revision 1.110 diff -u -p -u -p -r1.110 dwarf2loc.c --- dwarf2loc.c 27 Feb 2011 00:01:12 -0000 1.110 +++ dwarf2loc.c 4 Mar 2011 22:34:24 -0000 @@ -2687,8 +2687,11 @@ loclist_read_variable (struct symbol *sy set_value_optimized_out (val, 1); } else - val = dwarf2_evaluate_loc_desc (SYMBOL_TYPE (symbol), frame, data, size, - dlbaton->per_cu); + { + gdb_assert (frame); + val = dwarf2_evaluate_loc_desc (SYMBOL_TYPE (symbol), frame, + data, size, dlbaton->per_cu); + } return val; } --------------040601060909040103060301--