From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17109 invoked by alias); 4 Mar 2011 22:15:45 -0000 Received: (qmail 17100 invoked by uid 22791); 4 Mar 2011 22:15:45 -0000 X-SWARE-Spam-Status: No, hits=-5.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Mar 2011 22:15:41 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 987578003 for ; Fri, 4 Mar 2011 14:15:39 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost3.vmware.com (Postfix) with ESMTP id 8AB37CDA3A for ; Fri, 4 Mar 2011 14:15:39 -0800 (PST) Message-ID: <4D71648B.1090101@vmware.com> Date: Fri, 04 Mar 2011 22:15:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: "gdb-patches@sourceware.org" Subject: [RFA] mdebugread.c (psymtab_to_symtab_1): assert that 'fh' is not null Content-Type: multipart/mixed; boundary="------------070006060307020001070403" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00335.txt.bz2 This is a multi-part message in MIME format. --------------070006060307020001070403 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 86 This occurs along a path where fh *could* be null, and then we dereference it. OK? --------------070006060307020001070403 Content-Type: text/plain; name="null3.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="null3.txt" Content-length: 741 2011-03-04 Michael Snyder * mdebugread.c (psymtab_to_symtab_1): Assert fh is not null. Index: mdebugread.c =================================================================== RCS file: /cvs/src/src/gdb/mdebugread.c,v retrieving revision 1.120 diff -u -p -r1.120 mdebugread.c --- mdebugread.c 2 Mar 2011 23:54:16 -0000 1.120 +++ mdebugread.c 4 Mar 2011 22:10:46 -0000 @@ -4323,6 +4323,7 @@ psymtab_to_symtab_1 (struct partial_symt top_stack->blocktype = stFile; ext_ptr = PST_PRIVATE (pst)->extern_tab; + gdb_assert (fh); for (i = PST_PRIVATE (pst)->extern_count; --i >= 0; ext_ptr++) parse_external (ext_ptr, fh->fBigendian, pst->section_offsets, pst->objfile); --------------070006060307020001070403--