From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26471 invoked by alias); 4 Mar 2011 18:41:53 -0000 Received: (qmail 26456 invoked by uid 22791); 4 Mar 2011 18:41:52 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Mar 2011 18:41:50 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p24IfUkw009544 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 4 Mar 2011 13:41:30 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p24IfT33010190; Fri, 4 Mar 2011 13:41:29 -0500 Received: from [10.3.113.13] ([10.3.113.13]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p24IfRxA023675; Fri, 4 Mar 2011 13:41:28 -0500 Message-ID: <4D713257.5010302@redhat.com> Date: Fri, 04 Mar 2011 18:41:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.7 MIME-Version: 1.0 To: Tom Tromey CC: Michael Snyder , Tristan Gingold , "gdb-patches@sourceware.org" , "gcc-patches@gcc.gnu.org" Subject: Re: libiberty/cplus-dem.c, ada-demangle: plug memory leak. References: <4D70061C.10904@vmware.com> <20110303213008.GY30899@tyan-ft48-01.lab.bos.redhat.com> <4D700F5D.2030109@vmware.com> <807E3430-F4F7-464D-8E8A-527A86BA3D88@adacore.com> <4D712A5F.1040307__35010.4677411311$1299262072$gmane$org@vmware.com> <4D712F12.8050808__11842.7885965959$1299263268$gmane$org@vmware.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00308.txt.bz2 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 03/04/11 11:36, Tom Tromey wrote: > Michael> How come 'xfree' in gdb/utils.c still checks for null? > > I don't know, but I assume just because nobody has bothered to remove > the check. I think we also still have code doing `if (x) xfree (x);', > which is kind of doubly wrong :) We probably have similar crud in GCC as well; I vaguely recall a discussion and patches which removed some of this crud, but I doubt it's all been cleaned up. jeff -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJNcTJXAAoJEBRtltQi2kC7EboIAJyiVz4y0JXJbydigH2IKHVK yb13AVw5i6cE4cG4S0WVhOJxyxYVGMX83KzeEqJPLjuEQ45Pb/ePO+eCQkXFPUJM cDdk1WbcSa/TLd1DpcuJDlcEsD3XgkcZb7snhTwqJts8OOKNmKnCMdb0S5F6alBJ PeOmhXkk+O4Fw0IwrBH7dhZd6MHwFCzqZFwotEm01lsHKoOh4RYVh4V8ug1VVRCY bB7XuctXJgdtEyXqg/wjHObsGBViSdO8putOgFATKyedWDxGKKAVWyXK/pNIMX7v L/PSdm4/H0U0Ku0uDtxuGef4mUE1q5aq+zRWpHA2wNvAvZ1opiDZcaDGP1yeuEw= =LTVa -----END PGP SIGNATURE-----