On 03/01/2011 05:01 PM, Yao Qi wrote:
>>>> >> > +      if (displaced_in_arm_mode (regs))
>> > It would be somewhat nicer here to use dsc->is_thumb instead of
re-computing
>> > its value.  However, the displaced_read_reg function doesn't have
the dsc
>> > argument, which is annoying (and asymmetrical to
displaced_write_reg ...).
>> >
>> > So if you want to make the effort to change all call sites to pass
in dsc,
>> > this would be nice, but I guess I'm also OK with doing it as above.
>> >
> Let us move this change to another patch.
>

During writing thumb displaced stepping, we find that displaced_read_reg
can be refactored to avoid calling displaced_in_arm_mode every time.

OK to apply?

-- 
Yao (齐尧)