From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26720 invoked by alias); 4 Mar 2011 13:00:54 -0000 Received: (qmail 26710 invoked by uid 22791); 4 Mar 2011 13:00:54 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Mar 2011 13:00:48 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p24D0k1F021545 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 4 Mar 2011 08:00:46 -0500 Received: from [10.36.4.107] (vpn1-4-107.ams2.redhat.com [10.36.4.107]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p24D0iBX022513; Fri, 4 Mar 2011 08:00:45 -0500 Message-ID: <4D70E27E.5080806@redhat.com> Date: Fri, 04 Mar 2011 13:00:00 -0000 From: Nick Clifton User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Thunderbird/3.1.7 MIME-Version: 1.0 To: Michael Snyder CC: rth@redhat.com, bug-binutils@gnu.org, "gdb-patches@sourceware.org" Subject: Re: [RFA] archive.c, bsd_write_armap, fail if stat fails References: <4D6FE1F1.1010501@vmware.com> <20110303222506.GO13094@bubble.grove.modra.org> <4D7026A6.4090905@vmware.com> In-Reply-To: <4D7026A6.4090905@vmware.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00290.txt.bz2 Hi Miachael, > Alan Modra wrote: >> On Thu, Mar 03, 2011 at 10:46:09AM -0800, Michael Snyder wrote: >>> * archive.c (bsd_write_armap): Fail if stat fails. >> >> I think it would be better to just set the timestamp to zero if stat >> fails. There is precedent for this, eg. opncls.c:_maybe_make_executable. > > Err, can I leave that to you? Oops - I should have read all my emails first...