From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25711 invoked by alias); 4 Mar 2011 12:59:19 -0000 Received: (qmail 25703 invoked by uid 22791); 4 Mar 2011 12:59:19 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Mar 2011 12:59:13 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p24CxBUL020676 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 4 Mar 2011 07:59:11 -0500 Received: from [10.36.4.107] (vpn1-4-107.ams2.redhat.com [10.36.4.107]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p24Cx9A6024857; Fri, 4 Mar 2011 07:59:10 -0500 Message-ID: <4D70E220.7080601@redhat.com> Date: Fri, 04 Mar 2011 12:59:00 -0000 From: Nick Clifton User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Thunderbird/3.1.7 MIME-Version: 1.0 To: Michael Snyder CC: rth@redhat.com, bug-binutils@gnu.org, "gdb-patches@sourceware.org" Subject: Re: [RFA] archive.c, bsd_write_armap, fail if stat fails References: <4D6FE1F1.1010501@vmware.com> In-Reply-To: <4D6FE1F1.1010501@vmware.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00289.txt.bz2 Hi Michael. > Perhaps nit-picky -- what do you think? > 2011-03-03 Michael Snyder > > * archive.c (bsd_write_armap): Fail if stat fails. I am all for paranoid programming - please apply. Cheers Nick