From: Dave Korn <dave.korn.cygwin@gmail.com>
To: Mike Stump <mikestump@comcast.net>
Cc: Michael Snyder <msnyder@vmware.com>, DJ Delorie <dj@redhat.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA] libiberty/hashtab.c, higher_prime_index: avoid array overrun
Date: Fri, 04 Mar 2011 00:14:00 -0000 [thread overview]
Message-ID: <4D702EB6.80308@gmail.com> (raw)
In-Reply-To: <7C3548F1-7F55-4E3A-92F9-A41A82060F34@comcast.net>
On 03/03/2011 23:00, Mike Stump wrote:
> On Mar 3, 2011, at 2:26 PM, Michael Snyder wrote:
>> DJ Delorie wrote:
>>>> As written, the function will access element [30] of a 30-element array.
>>> Um, no?
>> Y-uh-huh!
>
> fight fight fight... :-) There can be only one.
I was just wondering whether now would be a good time to mention that having
prime-sized hash tables is only a workaround against the danger of someone
providing an inadequate hash function implementation in the first place?
cheers,
DaveK
next prev parent reply other threads:[~2011-03-04 0:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 22:04 Michael Snyder
2011-03-03 22:11 ` DJ Delorie
2011-03-03 22:26 ` Michael Snyder
2011-03-03 22:59 ` DJ Delorie
2011-03-07 2:59 ` Michael Snyder
2011-03-03 23:01 ` Mike Stump
2011-03-03 23:24 ` Michael Snyder
2011-03-04 0:14 ` Dave Korn [this message]
2011-03-04 0:19 ` DJ Delorie
2011-03-03 22:33 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D702EB6.80308@gmail.com \
--to=dave.korn.cygwin@gmail.com \
--cc=dj@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=mikestump@comcast.net \
--cc=msnyder@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox