From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 888 invoked by alias); 3 Mar 2011 23:39:28 -0000 Received: (qmail 879 invoked by uid 22791); 3 Mar 2011 23:39:27 -0000 X-SWARE-Spam-Status: No, hits=-5.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Mar 2011 23:39:23 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 700D513053; Thu, 3 Mar 2011 15:39:20 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost3.vmware.com (Postfix) with ESMTP id 64E61CD9C3; Thu, 3 Mar 2011 15:39:20 -0800 (PST) Message-ID: <4D7026A6.4090905@vmware.com> Date: Thu, 03 Mar 2011 23:39:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: Michael Snyder , nickc@redhat.com, rth@redhat.com, bug-binutils@gnu.org, "gdb-patches@sourceware.org" Subject: Re: [RFA] archive.c, bsd_write_armap, fail if stat fails References: <4D6FE1F1.1010501@vmware.com> <20110303222506.GO13094@bubble.grove.modra.org> In-Reply-To: <20110303222506.GO13094@bubble.grove.modra.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00233.txt.bz2 Alan Modra wrote: > On Thu, Mar 03, 2011 at 10:46:09AM -0800, Michael Snyder wrote: >> * archive.c (bsd_write_armap): Fail if stat fails. > > I think it would be better to just set the timestamp to zero if stat > fails. There is precedent for this, eg. opncls.c:_maybe_make_executable. > Err, can I leave that to you?