Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@vmware.com>
To: "H.J. Lu" <hjl.tools@gmail.com>,
	 "bug-binutils@gnu.org" <bug-binutils@gnu.org>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [RFA] elf64-x86-64.c, elf_x86_64_relocate_section, remove dead code.
Date: Thu, 03 Mar 2011 20:27:00 -0000	[thread overview]
Message-ID: <4D6FF996.9040700@vmware.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 66 bytes --]

Within this case statement, the conditional cannot be true.

OK?


[-- Attachment #2: elf64-x86-64.txt --]
[-- Type: text/plain, Size: 922 bytes --]

2011-03-03  Michael Snyder  <msnyder@vmware.com>

	* elf64-x86-64.c (elf_x86_64_relocate_section): Remove dead code.

Index: elf64-x86-64.c
===================================================================
RCS file: /cvs/src/src/bfd/elf64-x86-64.c,v
retrieving revision 1.212
diff -u -p -u -p -r1.212 elf64-x86-64.c
--- elf64-x86-64.c	17 Feb 2011 13:51:52 -0000	1.212
+++ elf64-x86-64.c	3 Mar 2011 20:23:40 -0000
@@ -2999,18 +2999,6 @@ elf_x86_64_relocate_section (bfd *output
 	      relocation = (base_got->output_section->vma
 			    + base_got->output_offset + off);
 
-	      if (r_type != R_X86_64_GOTPCREL
-		  && r_type != R_X86_64_GOTPCREL64)
-		{
-		  asection *gotplt;
-		  if (htab->elf.splt != NULL)
-		    gotplt = htab->elf.sgotplt;
-		  else
-		    gotplt = htab->elf.igotplt;
-		  relocation -= (gotplt->output_section->vma
-				 - gotplt->output_offset);
-		}
-
 	      goto do_relocation;
 	    }
 	}

             reply	other threads:[~2011-03-03 20:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-03 20:27 Michael Snyder [this message]
2011-03-03 22:32 ` Alan Modra
2011-03-04  0:39   ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D6FF996.9040700@vmware.com \
    --to=msnyder@vmware.com \
    --cc=bug-binutils@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=hjl.tools@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox