From: Michael Snyder <msnyder@vmware.com>
To: nickc@redhat.com, bug-binutils@gnu.org,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [RFA] peXXigen.c, _bfd_XXi_swap_aux_in, wrong size used in memcpy.
Date: Thu, 03 Mar 2011 18:09:00 -0000 [thread overview]
Message-ID: <4D6FD940.7050400@vmware.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 10 bytes --]
OK Nick?
[-- Attachment #2: peXXigen.txt --]
[-- Type: text/plain, Size: 1052 bytes --]
2011-03-03 Michael Snyder <msnyder@msnyder-server.eng.vmware.com>
* peXXigen.c (_bfd_XXi_swap_aux_in): Use E_FILNMNEN instead of
FILENMLEN, otherwise will overwrite array.
Index: peXXigen.c
===================================================================
RCS file: /cvs/src/src/bfd/peXXigen.c,v
retrieving revision 1.69
diff -u -p -u -p -r1.69 peXXigen.c
--- peXXigen.c 21 Dec 2010 15:24:38 -0000 1.69
+++ peXXigen.c 3 Mar 2011 18:03:44 -0000
@@ -249,7 +249,7 @@ _bfd_XXi_swap_aux_in (bfd * abfd,
in->x_file.x_n.x_offset = H_GET_32 (abfd, ext->x_file.x_n.x_offset);
}
else
- memcpy (in->x_file.x_fname, ext->x_file.x_fname, FILNMLEN);
+ memcpy (in->x_file.x_fname, ext->x_file.x_fname, E_FILNMLEN);
return;
case C_STAT:
@@ -323,7 +323,7 @@ _bfd_XXi_swap_aux_out (bfd * abfd,
H_PUT_32 (abfd, in->x_file.x_n.x_offset, ext->x_file.x_n.x_offset);
}
else
- memcpy (ext->x_file.x_fname, in->x_file.x_fname, FILNMLEN);
+ memcpy (ext->x_file.x_fname, in->x_file.x_fname, E_FILNMLEN);
return AUXESZ;
next reply other threads:[~2011-03-03 18:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 18:09 Michael Snyder [this message]
2011-03-03 19:13 ` Pedro Alves
2011-03-03 20:06 ` Michael Snyder
2011-03-03 21:07 ` Pedro Alves
2011-03-03 22:38 ` Alan Modra
2011-03-04 12:58 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6FD940.7050400@vmware.com \
--to=msnyder@vmware.com \
--cc=bug-binutils@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox