From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9303 invoked by alias); 3 Mar 2011 17:22:09 -0000 Received: (qmail 9293 invoked by uid 22791); 3 Mar 2011 17:22:06 -0000 X-SWARE-Spam-Status: No, hits=-5.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Mar 2011 17:22:01 +0000 Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id C6DB8E028 for ; Thu, 3 Mar 2011 09:21:59 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost2.vmware.com (Postfix) with ESMTP id BC1AB8ED3B for ; Thu, 3 Mar 2011 09:21:59 -0800 (PST) Message-ID: <4D6FCE37.1090902@vmware.com> Date: Thu, 03 Mar 2011 17:22:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [rfa] remote-fileio.c, remote_fileio_func_fstat, uninitialized st.st_ino. References: <4D6EBB4A.9080207@vmware.com> <20110303082857.GA10587@calimero.vinschen.de> <20110303092532.GW30306@adacore.com> <201103031004.02585.pedro@codesourcery.com> <20110303105029.GA22636@calimero.vinschen.de> In-Reply-To: <20110303105029.GA22636@calimero.vinschen.de> Content-Type: multipart/mixed; boundary="------------050104020809020008000903" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00185.txt.bz2 This is a multi-part message in MIME format. --------------050104020809020008000903 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-length: 1006 Corinna Vinschen wrote: > On Mar 3 10:04, Pedro Alves wrote: >> On Thursday 03 March 2011 09:25:32, Joel Brobecker wrote: >>>> I'm just wondering, can we assume that the stat structure has always an >>>> st_ino member? THere are checks for st_blocks and st_blksize in place >>>> already. Is the same required for st_ino? >>> I think it's fine, at least for now. The good news is that this >>> field is described in the Open Group's page for this type: >>> http://pubs.opengroup.org/onlinepubs/009695399/basedefs/sys/stat.h.html >>> So I think we can count on it (although, I don't know enough about C >>> to know how much authority this has) >>> >>> But, regardless, I think we can leave it be until such day where >>> we actually come across a system where the field actually does not >>> exist... When that happens, we can easily fix the build failure. >> Can't we just memset `st' instead? > > That would be the simplest solution. Afterwards, just set the > non-zero fields. OK, how about this? --------------050104020809020008000903 Content-Type: text/plain; name="fileio2.txt" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="fileio2.txt" Content-length: 1428 MjAxMS0wMy0wMyAgTWljaGFlbCBTbnlkZXIgIDxtc255ZGVyQHZtd2FyZS5j b20+CgoJKiByZW1vdGUtZmlsZWlvLmMgKHJlbW90ZV9maWxlaW9fZnVuY19m c3RhdCk6IEluaXRpYWxpemUgYWxsCglmaWVsZHMgb2Ygc3RydWN0ICdzdCcg dG8gemVyby4KCkluZGV4OiByZW1vdGUtZmlsZWlvLmMKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9zcmMvc3JjL2dkYi9yZW1vdGUt ZmlsZWlvLmMsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNDAKZGlmZiAtdSAt cCAtdSAtcCAtcjEuNDAgcmVtb3RlLWZpbGVpby5jCi0tLSByZW1vdGUtZmls ZWlvLmMJMjUgSmFuIDIwMTEgMTE6NTQ6MDAgLTAwMDAJMS40MAorKysgcmVt b3RlLWZpbGVpby5jCTMgTWFyIDIwMTEgMTc6MjA6MDYgLTAwMDAKQEAgLTEx NzMsMjAgKzExNzMsMTUgQEAgcmVtb3RlX2ZpbGVpb19mdW5jX2ZzdGF0IChj aGFyICpidWYpCiAgIGlmIChmZCA9PSBGSU9fRkRfQ09OU09MRV9JTiB8fCBm ZCA9PSBGSU9fRkRfQ09OU09MRV9PVVQpCiAgICAgewogICAgICAgcmVtb3Rl X2ZpbGVpb190b19maW9fdWludCAoMSwgZnN0LmZzdF9kZXYpOworICAgICAg bWVtc2V0ICgmc3QsIDAsIHNpemVvZiAoc3QpKTsKICAgICAgIHN0LnN0X21v ZGUgPSBTX0lGQ0hSIHwgKGZkID09IEZJT19GRF9DT05TT0xFX0lOID8gU19J UlVTUiA6IFNfSVdVU1IpOwogICAgICAgc3Quc3RfbmxpbmsgPSAxOwogI2lm ZGVmIEhBVkVfR0VUVUlECiAgICAgICBzdC5zdF91aWQgPSBnZXR1aWQgKCk7 Ci0jZWxzZQotICAgICAgc3Quc3RfdWlkID0gMDsKICNlbmRpZgogI2lmZGVm IEhBVkVfR0VUR0lECiAgICAgICBzdC5zdF9naWQgPSBnZXRnaWQgKCk7Ci0j ZWxzZQotICAgICAgc3Quc3RfZ2lkID0gMDsKICNlbmRpZgotICAgICAgc3Qu c3RfcmRldiA9IDA7Ci0gICAgICBzdC5zdF9zaXplID0gMDsKICNpZmRlZiBI QVZFX1NUUlVDVF9TVEFUX1NUX0JMS1NJWkUKICAgICAgIHN0LnN0X2Jsa3Np emUgPSA1MTI7CiAjZW5kaWYK --------------050104020809020008000903--