From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-79032-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 30903 invoked by alias); 2 Mar 2011 23:56:24 -0000
Received: (qmail 30895 invoked by uid 22791); 2 Mar 2011 23:56:24 -0000
X-SWARE-Spam-Status: No, hits=-5.1 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,TW_CP,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Mar 2011 23:56:18 +0000
Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124])	by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 5AB2D31009;	Wed,  2 Mar 2011 15:56:17 -0800 (PST)
Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138])	by mailhost4.vmware.com (Postfix) with ESMTP id 4F459C9F76;	Wed,  2 Mar 2011 15:56:17 -0800 (PST)
Message-ID: <4D6ED920.6090206@vmware.com>
Date: Wed, 02 Mar 2011 23:56:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 2.0.0.24 (X11/20101201)
MIME-Version: 1.0
To: Pedro Alves <pedro@codesourcery.com>
CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [commit] printcmd.c, print_scalar_formatted, use strncpy.
References: <4D6ECC07.40905@vmware.com> <201103022341.55237.pedro@codesourcery.com>
In-Reply-To: <201103022341.55237.pedro@codesourcery.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-03/txt/msg00145.txt.bz2

Pedro Alves wrote:
> On Wednesday 02 March 2011 23:00:23, Michael Snyder wrote:
>> strncpy2.txt
>>   2011-03-02  Michael Snyder  <msnyder@vmware.com>
>>
>>         * printcmd.c (print_scalar_formatted): Use strncpy for safety.
>>
>> Index: printcmd.c
>> ===================================================================
>> RCS file: /cvs/src/src/gdb/printcmd.c,v
>> retrieving revision 1.192
>> diff -u -p -u -p -r1.192 printcmd.c
>> --- printcmd.c  26 Feb 2011 02:07:08 -0000      1.192
>> +++ printcmd.c  2 Mar 2011 22:55:38 -0000
>> @@ -533,7 +533,7 @@ print_scalar_formatted (const void *vala
>>             if (*cp == '\0')
>>               cp--;
>>           }
>> -       strcpy (buf, cp);
>> +       strncpy (buf, cp, sizeof (bits));
>>         fputs_filtered (buf, stream);
>>        }
>>        break;
> 
> We've been through this recently...  This is not safe.
> 

I'm slow today -- how is it not safe?

(note that sizeof (bits) is smaller than sizeof (buff)).