From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-79003-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29862 invoked by alias); 2 Mar 2011 18:28:08 -0000
Received: (qmail 29854 invoked by uid 22791); 2 Mar 2011 18:28:07 -0000
X-SWARE-Spam-Status: No, hits=-5.1 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Mar 2011 18:28:03 +0000
Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167])	by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 828134D00F;	Wed,  2 Mar 2011 10:28:02 -0800 (PST)
Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138])	by mailhost2.vmware.com (Postfix) with ESMTP id 754C68EF70;	Wed,  2 Mar 2011 10:28:02 -0800 (PST)
Message-ID: <4D6E8C32.5090009@vmware.com>
Date: Wed, 02 Mar 2011 18:28:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 2.0.0.24 (X11/20101201)
MIME-Version: 1.0
To: Pedro Alves <pedro@codesourcery.com>
CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,  Mark Kettenis <mark.kettenis@xs4all.nl>
Subject: Re: [RFA] linux-nat.c, linux_thread_alive, user errno instead of err
References: <4D6D8774.3090506@vmware.com> <201103020118.03628.pedro@codesourcery.com> <4D6E85EE.6090209@vmware.com> <201103021803.54297.pedro@codesourcery.com>
In-Reply-To: <201103021803.54297.pedro@codesourcery.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-03/txt/msg00116.txt.bz2

Pedro Alves wrote:
> On Wednesday 02 March 2011 18:01:18, Michael Snyder wrote:
>> Pedro Alves wrote:
>>>>> --- linux-nat.c	1 Mar 2011 00:40:22 -0000	1.197
>>>>> +++ linux-nat.c	1 Mar 2011 23:50:34 -0000
>>>>> @@ -4045,7 +4045,7 @@ linux_thread_alive (ptid_t ptid)
>>>>>      fprintf_unfiltered (gdb_stdlog,
>>>>>  			"LLTA: KILL(SIG0) %s (%s)\n",
>>>>>  			target_pid_to_str (ptid),
>>>>> -			err ? safe_strerror (err) : "OK");
>>>>> +			err ? safe_strerror (errno) : "OK");
>>> Not 100% correct.  target_pid_to_str is allowed to
>>> clobber errno (as any function call is).
>> OK.  How about this then?
> 
> That's it, thanks.
> 

So committed.  Thanks for the review.