From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-79002-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 21941 invoked by alias); 2 Mar 2011 18:13:23 -0000
Received: (qmail 21931 invoked by uid 22791); 2 Mar 2011 18:13:22 -0000
X-SWARE-Spam-Status: No, hits=-5.0 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,TW_XT,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Mar 2011 18:13:18 +0000
Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167])	by smtp-outbound-1.vmware.com (Postfix) with ESMTP id B47A16013;	Wed,  2 Mar 2011 10:13:16 -0800 (PST)
Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138])	by mailhost2.vmware.com (Postfix) with ESMTP id AB32F8EEA8;	Wed,  2 Mar 2011 10:13:16 -0800 (PST)
Message-ID: <4D6E88BC.9080905@vmware.com>
Date: Wed, 02 Mar 2011 18:13:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 2.0.0.24 (X11/20101201)
MIME-Version: 1.0
To: Ulrich Weigand <uweigand@de.ibm.com>
CC: Yao Qi <yao@codesourcery.com>,  "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: Fix magic number in arm-tdep.c
References: <201103021412.p22EC5vZ015623@d06av02.portsmouth.uk.ibm.com>
In-Reply-To: <201103021412.p22EC5vZ015623@d06av02.portsmouth.uk.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-03/txt/msg00115.txt.bz2

Ulrich Weigand wrote:
> Yao Qi wrote:
> 
>> 	* gdb/arm-tdep.c (shifted_reg_val): Replace magic number 15 with
>> 	ARM_PC_REGNUM.
>> 	(thumb_get_next_pc_raw, arm_get_next_pc_raw): Likewise.
>> 	(displaced_write_reg, displaced_read_reg): Likewise.
>> 	(copy_ldr_str_ldrb_strb, cleanup_block_load_all): Likewise.
>> 	(cleanup_block_load_pc, copy_block_xfer): Likewise.
>> 	(cleanup_branch): Replace magic number 14 and 15 with
>> 	ARM_LR_REGNUM and ARM_PC_REGNUM respectively.
> 
> This is OK, but please keep the indentation in cases like:
> 
>> -		nextpc = (rn == 15) ? pc_val + 8
>> +		nextpc = (rn == ARM_PC_REGNUM) ? pc_val + 8
>>  				    : get_frame_register_unsigned (frame, rn);
> 
> (? and : should remain in the same column).
> 

I don't agree - : is an operator and should be indented by just two 
spaces.  As emacs does by default.