From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24447 invoked by alias); 2 Mar 2011 04:41:08 -0000 Received: (qmail 24436 invoked by uid 22791); 2 Mar 2011 04:41:06 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Mar 2011 04:41:00 +0000 Received: (qmail 13911 invoked from network); 2 Mar 2011 04:40:58 -0000 Received: from unknown (HELO ?192.168.0.101?) (yao@127.0.0.2) by mail.codesourcery.com with ESMTPA; 2 Mar 2011 04:40:58 -0000 Message-ID: <4D6DCA56.4030008@codesourcery.com> Date: Wed, 02 Mar 2011 04:41:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101208 Lightning/1.0b2 Thunderbird/3.1.7 MIME-Version: 1.0 To: Tom Tromey CC: Joel Brobecker , Pedro Alves , gdb-patches@sourceware.org Subject: Re: [rfa/rfc] Build libcommon.a for gdb and gdbserver References: <4D550834.6080807@codesourcery.com> <4D55FAB4.7090001@codesourcery.com> <4D648A5F.8050607@codesourcery.com> <4D65D5B7.1000902@codesourcery.com> <20110301044144.GH30306@adacore.com> <4D6C882B.7010801@codesourcery.com> In-Reply-To: Content-Type: multipart/mixed; boundary="------------020400000109030103050604" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00082.txt.bz2 This is a multi-part message in MIME format. --------------020400000109030103050604 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-length: 675 On 03/01/2011 10:36 PM, Tom Tromey wrote: > > common/Makefile: configure-common common/Makefile.in config.status @frags@ > CONFIG_FILES="common/Makefile" \ > CONFIG_COMMANDS="depfiles" \ > CONFIG_HEADERS= \ > CONFIG_LINKS= \ > $(SHELL) config.status > > > But since we are running a separate configure script in common/, it is > incorrect to run this directory's config.status to try to make it. > > Usually one doesn't bother with this stuff -- just recurse and let the > subdir Makefile rebuild itself as needed. We can remove this rule, and let common/Makefile to rebuild itself. Fixed in this patch. -- Yao (齐尧) --------------020400000109030103050604 Content-Type: text/x-patch; name="makefile-in-fix-0302.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="makefile-in-fix-0302.patch" Content-length: 1649 gdb/ * Makefile.in (configure-common): Remove. Let Makefile in dir common to rebuild itself. (common/Makefile): Likewise. diff --git a/gdb/Makefile.in b/gdb/Makefile.in index 6363773..ef78329 100644 --- a/gdb/Makefile.in +++ b/gdb/Makefile.in @@ -1174,22 +1174,6 @@ all-lib: gnulib/Makefile $(LIBCOMMON): $(LIBCOMMON_DIR)/Makefile @$(MAKE) $(FLAGS_TO_PASS) DO=all DODIRS=common subdir_do -configure-common: - @: $(MAKE); $(unstage) - @r=`${PWD_COMMAND}`; export r; \ - s=`cd $(srcdir); ${PWD_COMMAND}`; export s; \ - test ! -f common/Makefile || exit 0; \ - $(SHELL) $(srcdir)/../mkinstalldirs common ; \ - $(HOST_EXPORTS) \ - echo Configuring in common; \ - cd "common" || exit 1; \ - commondir="$$s/common"; \ - srcdiroption="--srcdir=$${commondir}"; \ - $(SHELL) $${commondir}/configure --enable-gdbserver=no \ - $(HOST_CONFIGARGS) --build=${build_alias} --host=${host_alias} \ - --target=${target_alias} $${srcdiroption} \ - || exit 1 - # Convenience rule to handle recursion. .PHONY: all-data-directory all-data-directory: data-directory/Makefile @@ -1325,13 +1309,6 @@ data-directory/Makefile: data-directory/Makefile.in config.status @frags@ CONFIG_LINKS= \ $(SHELL) config.status -common/Makefile: configure-common common/Makefile.in config.status @frags@ - CONFIG_FILES="common/Makefile" \ - CONFIG_COMMANDS="depfiles" \ - CONFIG_HEADERS= \ - CONFIG_LINKS= \ - $(SHELL) config.status - config.h: stamp-h ; @true stamp-h: $(srcdir)/config.in config.status CONFIG_HEADERS=config.h:config.in \ --------------020400000109030103050604--