From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18453 invoked by alias); 2 Mar 2011 01:03:12 -0000 Received: (qmail 18444 invoked by uid 22791); 2 Mar 2011 01:03:11 -0000 X-SWARE-Spam-Status: No, hits=-5.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Mar 2011 01:03:05 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 832BD13018; Tue, 1 Mar 2011 17:03:04 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost3.vmware.com (Postfix) with ESMTP id 6EEDACD961; Tue, 1 Mar 2011 17:03:04 -0800 (PST) Message-ID: <4D6D9748.7080608@vmware.com> Date: Wed, 02 Mar 2011 01:03:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: "gdb-patches@sourceware.org" CC: Pedro Alves Subject: [RFA] bfd-target.c, target_bfd_reopen, check for error Content-Type: multipart/mixed; boundary="------------080307030504000904020009" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00074.txt.bz2 This is a multi-part message in MIME format. --------------080307030504000904020009 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 111 This is the only instance in which build_section_table is called without being checked for error return. OK? --------------080307030504000904020009 Content-Type: text/plain; name="reopen.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="reopen.txt" Content-length: 893 2011-03-01 Michael Snyder * bfd-target.c (target_bfd_reopen): Check for failure. Index: bfd-target.c =================================================================== RCS file: /cvs/src/src/gdb/bfd-target.c,v retrieving revision 1.17 diff -u -p -u -p -r1.17 bfd-target.c --- bfd-target.c 1 Jan 2011 15:32:57 -0000 1.17 +++ bfd-target.c 2 Mar 2011 01:00:25 -0000 @@ -85,7 +85,13 @@ target_bfd_reopen (struct bfd *bfd) data = XZALLOC (struct target_bfd_data); data->bfd = bfd; - build_section_table (bfd, &data->table.sections, &data->table.sections_end); + if (build_section_table (bfd, &data->table.sections, + &data->table.sections_end)) + { + xfree (data); + error (_("Failed to re-open '%s': %s"), + bfd_get_filename (bfd), bfd_errmsg (bfd_get_error ())); + } t = XZALLOC (struct target_ops); t->to_shortname = "bfd"; --------------080307030504000904020009--