From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9440 invoked by alias); 1 Mar 2011 21:55:35 -0000 Received: (qmail 9431 invoked by uid 22791); 1 Mar 2011 21:55:34 -0000 X-SWARE-Spam-Status: No, hits=-5.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Mar 2011 21:55:29 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 0CED842006; Tue, 1 Mar 2011 13:55:28 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost3.vmware.com (Postfix) with ESMTP id 00F31CD9F0; Tue, 1 Mar 2011 13:55:28 -0800 (PST) Message-ID: <4D6D6B4F.1020505@vmware.com> Date: Tue, 01 Mar 2011 21:55:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: Pedro Alves CC: "gdb-patches@sourceware.org" Subject: Re: [commit] py-prettyprint.c, val may be null References: <4D6D5F71.5040802@vmware.com> <201103012124.33473.pedro@codesourcery.com> <4D6D67E8.9040402@vmware.com> <201103012146.10195.pedro@codesourcery.com> In-Reply-To: <201103012146.10195.pedro@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00058.txt.bz2 Pedro Alves wrote: > On Tuesday 01 March 2011 21:40:56, Michael Snyder wrote: > >> In that case, the later check for null is superfluous. >> Is this better? > > Yes, I think so. > Thanks, checked in.