From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17404 invoked by alias); 1 Mar 2011 21:41:06 -0000 Received: (qmail 17335 invoked by uid 22791); 1 Mar 2011 21:41:05 -0000 X-SWARE-Spam-Status: No, hits=-5.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Mar 2011 21:41:00 +0000 Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id A49241A012; Tue, 1 Mar 2011 13:40:56 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost4.vmware.com (Postfix) with ESMTP id 97285C9FE7; Tue, 1 Mar 2011 13:40:56 -0800 (PST) Message-ID: <4D6D67E8.9040402@vmware.com> Date: Tue, 01 Mar 2011 21:41:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: Pedro Alves CC: "gdb-patches@sourceware.org" Subject: Re: [commit] py-prettyprint.c, val may be null References: <4D6D5F71.5040802@vmware.com> <201103012124.33473.pedro@codesourcery.com> In-Reply-To: <201103012124.33473.pedro@codesourcery.com> Content-Type: multipart/mixed; boundary="------------060400070100050700040507" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00052.txt.bz2 This is a multi-part message in MIME format. --------------060400070100050700040507 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Content-length: 535 Pedro Alves wrote: > On Tuesday 01 March 2011 21:04:49, Michael Snyder wrote: >> 2011-03-01 Michael Snyder >> >> * python/py-prettyprint.c (apply_val_pretty_printer): VAL may >> be null. > > How? Coverity assumes it may be null if it's checked for null. > I think it could a while ago, but not anymore. I've recently > made sure val_print always gets a non-NULL value, and we'd now > crash elsewhere otherwise. > In that case, the later check for null is superfluous. Is this better? --------------060400070100050700040507 Content-Type: text/plain; name="reversenull7.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="reversenull7.txt" Content-length: 1888 2011-03-01 Michael Snyder * python/py-prettyprint.c (apply_val_pretty_printer): Remove superfluous null check. Index: python/py-prettyprint.c =================================================================== RCS file: /cvs/src/src/gdb/python/py-prettyprint.c,v retrieving revision 1.22 diff -u -p -u -p -r1.22 py-prettyprint.c --- python/py-prettyprint.c 1 Mar 2011 21:03:22 -0000 1.22 +++ python/py-prettyprint.c 1 Mar 2011 21:38:59 -0000 @@ -692,8 +692,7 @@ apply_val_pretty_printer (struct type *t enum string_repr_result print_result; /* No pretty-printer support for unavailable values. */ - if (val && !value_bytes_available (val, embedded_offset, - TYPE_LENGTH (type))) + if (!value_bytes_available (val, embedded_offset, TYPE_LENGTH (type))) return 0; cleanups = ensure_python_env (gdbarch, language); @@ -703,16 +702,14 @@ apply_val_pretty_printer (struct type *t valaddr += embedded_offset; value = value_from_contents_and_address (type, valaddr, address + embedded_offset); - if (val != NULL) - { - set_value_component_location (value, val); - /* set_value_component_location resets the address, so we may - need to set it again. */ - if (VALUE_LVAL (value) != lval_internalvar - && VALUE_LVAL (value) != lval_internalvar_component - && VALUE_LVAL (value) != lval_computed) - set_value_address (value, address + embedded_offset); - } + + set_value_component_location (value, val); + /* set_value_component_location resets the address, so we may + need to set it again. */ + if (VALUE_LVAL (value) != lval_internalvar + && VALUE_LVAL (value) != lval_internalvar_component + && VALUE_LVAL (value) != lval_computed) + set_value_address (value, address + embedded_offset); val_obj = value_to_value_object (value); if (! val_obj) --------------060400070100050700040507--