Re: [commit] py-prettyprint.c, val may be null

Pedro Alves
2011-03-01T21:24:46Z

On Tuesday 01 March 2011 21:04:49, Michael Snyder wrote:
> 2011-03-01 Michael Snyder <msnyder@vmware.com>
>
> * python/py-prettyprint.c (apply_val_pretty_printer): VAL may
> be null.

How? I think it could a while ago, but not anymore. I've recently
made sure val_print always gets a non-NULL value, and we'd now
crash elsewhere otherwise.

--
Pedro Alves

>
> Index: python/py-prettyprint.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/python/py-prettyprint.c,v
> retrieving revision 1.21
> diff -u -p -u -p -r1.21 py-prettyprint.c
> --- python/py-prettyprint.c 14 Feb 2011 11:10:53 -0000 1.21
> +++ python/py-prettyprint.c 1 Mar 2011 21:02:05 -0000
> @@ -692,7 +692,8 @@ apply_val_pretty_printer (struct type *t
> enum string_repr_result print_result;
>
> /* No pretty-printer support for unavailable values. */
> - if (!value_bytes_available (val, embedded_offset, TYPE_LENGTH (type)))
> + if (val && !value_bytes_available (val, embedded_offset,
> + TYPE_LENGTH (type)))
> return 0;
>