From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20726 invoked by alias); 1 Mar 2011 20:25:54 -0000 Received: (qmail 20718 invoked by uid 22791); 1 Mar 2011 20:25:54 -0000 X-SWARE-Spam-Status: No, hits=-5.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Mar 2011 20:25:50 +0000 Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 928904000E for ; Tue, 1 Mar 2011 12:25:46 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost2.vmware.com (Postfix) with ESMTP id 89FD98EE9A for ; Tue, 1 Mar 2011 12:25:46 -0800 (PST) Message-ID: <4D6D564A.8080403@vmware.com> Date: Tue, 01 Mar 2011 20:25:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: "gdb-patches@sourceware.org" Subject: [commit] record.c (record_restore): Check pointer before use. Content-Type: multipart/mixed; boundary="------------090507010804040300030606" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00041.txt.bz2 This is a multi-part message in MIME format. --------------090507010804040300030606 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 13 checked in. --------------090507010804040300030606 Content-Type: text/plain; name="reversenull1.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="reversenull1.txt" Content-length: 894 2011-03-01 Michael Snyder * reverse.c (record_restore): Move null-check to before pointer dereference. Index: record.c =================================================================== RCS file: /cvs/src/src/gdb/record.c,v retrieving revision 1.57 diff -u -p -u -p -r1.57 record.c --- record.c 10 Jan 2011 20:38:50 -0000 1.57 +++ record.c 1 Mar 2011 20:23:33 -0000 @@ -2214,12 +2214,12 @@ record_restore (void) /* Now need to find our special note section. */ osec = bfd_get_section_by_name (core_bfd, "null0"); + if (osec == NULL) + return; osec_size = bfd_section_size (core_bfd, osec); if (record_debug) fprintf_unfiltered (gdb_stdlog, "Find precord section %s.\n", osec ? "succeeded" : "failed"); - if (osec == NULL) - return; if (record_debug) fprintf_unfiltered (gdb_stdlog, "%s", bfd_section_name (core_bfd, osec)); --------------090507010804040300030606--