From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6862 invoked by alias); 1 Mar 2011 18:51:58 -0000 Received: (qmail 6853 invoked by uid 22791); 1 Mar 2011 18:51:57 -0000 X-SWARE-Spam-Status: No, hits=-5.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Mar 2011 18:51:52 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 0AA8E5A02A; Tue, 1 Mar 2011 10:51:50 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost3.vmware.com (Postfix) with ESMTP id 03235CD9E6; Tue, 1 Mar 2011 10:51:50 -0800 (PST) Message-ID: <4D6D4045.9050202@vmware.com> Date: Tue, 01 Mar 2011 18:51:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: Yao Qi CC: "gdb-patches@sourceware.org" Subject: Re: [commit] objc-lang.c, classes_info, avoid string overrun References: <4D6C4FDB.1030201@vmware.com> <4D6C6856.8080501@codesourcery.com> In-Reply-To: <4D6C6856.8080501@codesourcery.com> Content-Type: multipart/mixed; boundary="------------020007000504090206010401" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00036.txt.bz2 This is a multi-part message in MIME format. --------------020007000504090206010401 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-length: 385 Yao Qi wrote: > On 03/01/2011 09:46 AM, Michael Snyder wrote: >> - if (sizeof (myregexp) < strlen (regexp) + 1) >> + if (sizeof (myregexp) < strlen (regexp) + 4) >> error (_("Regexp is too long: %s"), regexp); >> strcpy(myregexp, regexp); > > It is a little bit confusing when people read this code. We may need a > short comment here. > Okey dokey, see attached. --------------020007000504090206010401 Content-Type: text/plain; name="comment.txt" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="comment.txt" Content-length: 1436 MjAxMS0wMy0wMSAgTWljaGFlbCBTbnlkZXIgIDxtc255ZGVyQHZtd2FyZS5j b20+CgoJKiBvYmpjLWxhbmcuYyAoc2VsZWN0b3JzX2luZm8pOiBBZGQgZXhw bGFuaXRvcnkgY29tbWVudC4KCShjbGFzc2VzX2luZm8pOiBEaXR0by4KCklu ZGV4OiBvYmpjLWxhbmcuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBm aWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL29iamMtbGFuZy5jLHYKcmV0cmlldmlu ZyByZXZpc2lvbiAxLjk0CmRpZmYgLXUgLXAgLXUgLXAgLXIxLjk0IG9iamMt bGFuZy5jCi0tLSBvYmpjLWxhbmcuYwkxIE1hciAyMDExIDAxOjQ0OjI0IC0w MDAwCTEuOTQKKysrIG9iamMtbGFuZy5jCTEgTWFyIDIwMTEgMTg6NDk6NDEg LTAwMDAKQEAgLTcyMCw2ICs3MjAsNyBAQCBzZWxlY3RvcnNfaW5mbyAoY2hh ciAqcmVnZXhwLCBpbnQgZnJvbV90CiAJc3RyY3B5KG15cmVnZXhwLCAiLipd Iik7CiAgICAgICBlbHNlCiAJeworCSAgLyogQWxsb3cgYSBmZXcgZXh0cmEg Ynl0ZXMgYmVjYXVzZSBvZiB0aGUgc3RyY2F0IGJlbG93LiAgKi8KIAkgIGlm IChzaXplb2YgKG15cmVnZXhwKSA8IHN0cmxlbiAocmVnZXhwKSArIDQpCiAJ ICAgIGVycm9yIChfKCJSZWdleHAgaXMgdG9vIGxvbmc6ICVzIiksIHJlZ2V4 cCk7CiAJICBzdHJjcHkobXlyZWdleHAsIHJlZ2V4cCk7CkBAIC04NjMsNiAr ODY0LDcgQEAgY2xhc3Nlc19pbmZvIChjaGFyICpyZWdleHAsIGludCBmcm9t X3R0eQogICAgIHN0cmNweShteXJlZ2V4cCwgIi4qICIpOwkvKiBOdWxsIGlu cHV0OiBtYXRjaCBhbGwgb2JqYyBjbGFzc2VzLiAgKi8KICAgZWxzZQogICAg IHsKKyAgICAgIC8qIEFsbG93IGEgZmV3IGV4dHJhIGJ5dGVzIGJlY2F1c2Ug b2YgdGhlIHN0cmNhdCBiZWxvdy4gICovCiAgICAgICBpZiAoc2l6ZW9mICht eXJlZ2V4cCkgPCBzdHJsZW4gKHJlZ2V4cCkgKyA0KQogCWVycm9yIChfKCJS ZWdleHAgaXMgdG9vIGxvbmc6ICVzIiksIHJlZ2V4cCk7CiAgICAgICBzdHJj cHkobXlyZWdleHAsIHJlZ2V4cCk7Cg== --------------020007000504090206010401--