From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27812 invoked by alias); 1 Mar 2011 02:09:01 -0000 Received: (qmail 27762 invoked by uid 22791); 1 Mar 2011 02:09:00 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail3.caviumnetworks.com (HELO mail3.caviumnetworks.com) (12.108.191.235) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Mar 2011 02:08:54 +0000 Received: from caexch01.caveonetworks.com (Not Verified[192.168.16.9]) by mail3.caviumnetworks.com with MailMarshal (v6,7,2,8378) id ; Mon, 28 Feb 2011 18:09:46 -0800 Received: from caexch01.caveonetworks.com ([192.168.16.9]) by caexch01.caveonetworks.com with Microsoft SMTPSVC(6.0.3790.4675); Mon, 28 Feb 2011 18:08:52 -0800 Received: from dd1.caveonetworks.com ([12.108.191.236]) by caexch01.caveonetworks.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 28 Feb 2011 18:08:52 -0800 Message-ID: <4D6C5533.80609@caviumnetworks.com> Date: Tue, 01 Mar 2011 02:09:00 -0000 From: David Daney User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10 MIME-Version: 1.0 To: Michael Snyder CC: "gdb-patches@sourceware.org" Subject: Re: [commit] linux-nat.c, linux_handle_extended_wait: delete unused variable References: <4D6C40CC.6010900@vmware.com> In-Reply-To: <4D6C40CC.6010900@vmware.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00010.txt.bz2 On 02/28/2011 04:41 PM, Michael Snyder wrote: > checked in. > > > > 2011-02-28 Michael Snyder > > * linux-nat.c (linux_handle_extended_wait): Delete unused variable. I'm probably being pedantic, but that is not entirely accurate in this case. It is more like: Rewrite by nesting expressions to use fewer declared variables. David Daney > > Index: linux-nat.c > =================================================================== > RCS file: /cvs/src/src/gdb/linux-nat.c,v > retrieving revision 1.196 > diff -u -p -u -p -r1.196 linux-nat.c > --- linux-nat.c 27 Feb 2011 16:25:37 -0000 1.196 > +++ linux-nat.c 1 Mar 2011 00:39:00 -0000 > @@ -2198,8 +2198,6 @@ linux_handle_extended_wait (struct lwp_i > if (event == PTRACE_EVENT_FORK > && linux_fork_checkpointing_p (GET_PID (lp->ptid))) > { > - struct fork_info *fp; > - > /* Handle checkpointing by linux-fork.c here as a special > case. We don't want the follow-fork-mode or 'catch fork' > to interfere with this. */ > @@ -2209,9 +2207,8 @@ linux_handle_extended_wait (struct lwp_i > detach_breakpoints (new_pid); > > /* Retain child fork in ptrace (stopped) state. */ > - fp = find_fork_pid (new_pid); > - if (!fp) > - fp = add_fork (new_pid); > + if (!find_fork_pid (new_pid)) > + add_fork (new_pid); > > /* Report as spurious, so that infrun doesn't want to follow > this fork. We're actually doing an infcall in