From: Michael Snyder <msnyder@vmware.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: "brobecker@adacore.com" <brobecker@adacore.com>,
"jan.kratochvil@redhat.com" <jan.kratochvil@redhat.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFC] Compile GDB with -Wshadow?
Date: Mon, 28 Feb 2011 18:15:00 -0000 [thread overview]
Message-ID: <4D6BE621.7030400@vmware.com> (raw)
In-Reply-To: <201102280925.p1S9PceP018704@glazunov.sibelius.xs4all.nl>
Mark Kettenis wrote:
>> Date: Mon, 28 Feb 2011 11:39:49 +0400
>> From: Joel Brobecker <brobecker@adacore.com>
>>
>>> That would be great but it produces now 627 errors, I am not going to fix
>>> them, they look each one needs a specific fix.
>> :-(. Completely impractical at this stage. It's really surprising
>> that we would have so many errors of this kind...
>
> Well they're not errors per-se. Bad style perhaps, but that of course
> can be argued.
The ones I pointed out were all shadowing of a parameter.
These are probably shadowing of an outer scope.
As you say, not really errors in either case, but surely
a potential source of confusion for maintainers.
next prev parent reply other threads:[~2011-02-28 18:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-26 23:26 [rfa] function parameter shadowed by local variable in opencl-lang.c Michael Snyder
2011-02-26 23:36 ` Michael Snyder
2011-02-28 4:57 ` Joel Brobecker
2011-02-28 5:01 ` [RFC] Compile GDB with -Wshadow? (was: "Re: [rfa] function parameter shadowed by local variable in opencl-lang.c") Joel Brobecker
2011-02-28 5:39 ` Jan Kratochvil
2011-02-28 9:09 ` Joel Brobecker
2011-02-28 9:29 ` Mark Kettenis
2011-02-28 18:15 ` Michael Snyder [this message]
2011-02-28 15:48 ` [RFC] Compile GDB with -Wshadow? Tom Tromey
2011-02-28 15:23 ` [rfa] function parameter shadowed by local variable in opencl-lang.c Ulrich Weigand
2011-02-28 18:43 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6BE621.7030400@vmware.com \
--to=msnyder@vmware.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox