From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5632 invoked by alias); 28 Feb 2011 02:15:55 -0000 Received: (qmail 5621 invoked by uid 22791); 28 Feb 2011 02:15:53 -0000 X-SWARE-Spam-Status: No, hits=-4.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 28 Feb 2011 02:15:49 +0000 Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 087D127005 for ; Sun, 27 Feb 2011 18:15:48 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost4.vmware.com (Postfix) with ESMTP id 035C0C9E04 for ; Sun, 27 Feb 2011 18:15:48 -0800 (PST) Message-ID: <4D6B0553.6010803@vmware.com> Date: Mon, 28 Feb 2011 04:10:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: "gdb-patches@sourceware.org" Subject: [commit] objc-lang.c: avoid string overrun Content-Type: multipart/mixed; boundary="------------010501060401020706070308" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00869.txt.bz2 This is a multi-part message in MIME format. --------------010501060401020706070308 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 0 --------------010501060401020706070308 Content-Type: text/plain; name="strncpy2.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="strncpy2.txt" Content-length: 726 2011-02-27 Michael Snyder * objc-lang.c (selectors_info): Prevent string overrun. Index: objc-lang.c =================================================================== RCS file: /cvs/src/src/gdb/objc-lang.c,v retrieving revision 1.91 diff -u -p -u -p -r1.91 objc-lang.c --- objc-lang.c 10 Jan 2011 20:38:49 -0000 1.91 +++ objc-lang.c 28 Feb 2011 02:13:37 -0000 @@ -720,7 +720,7 @@ selectors_info (char *regexp, int from_t strcpy(myregexp, ".*]"); else { - strcpy(myregexp, regexp); + strncpy(myregexp, regexp, sizeof (myregexp) - 1); if (myregexp[strlen(myregexp) - 1] == '$') /* end of selector */ myregexp[strlen(myregexp) - 1] = ']'; /* end of method name */ else --------------010501060401020706070308--