From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14951 invoked by alias); 27 Feb 2011 20:57:39 -0000 Received: (qmail 14942 invoked by uid 22791); 27 Feb 2011 20:57:38 -0000 X-SWARE-Spam-Status: No, hits=-5.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 27 Feb 2011 20:57:34 +0000 Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 61B7239012; Sun, 27 Feb 2011 12:57:33 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost4.vmware.com (Postfix) with ESMTP id 51130C9F15; Sun, 27 Feb 2011 12:57:33 -0800 (PST) Message-ID: <4D6ABABC.6070102@vmware.com> Date: Sun, 27 Feb 2011 21:03:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: Pedro Alves CC: "gdb-patches@sourceware.org" Subject: Re: [rfa] Make get_number_or_range accept value history references References: <4D66AD46.204@vmware.com> <201102251155.57072.pedro@codesourcery.com> <4D682303.5040809@vmware.com> <201102261152.24496.pedro@codesourcery.com> In-Reply-To: <201102261152.24496.pedro@codesourcery.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00841.txt.bz2 Pedro Alves wrote: > On Friday 25 February 2011 21:45:39, Michael Snyder wrote: > >> OK, a major re-write! ;-) > > Thanks. > > I now noticed linespec.c:decode_dollar also does > the same thing, another candidate for refactoring/reuse. I'll look at it as a separate pass. > What does the _ref mean in value_from_history_ref? History reference. >> +gdb_test "disable \$1foo" \ >> + "Convenience variable must have integer value.*" \ >> + "disable with badly formed history value" > > This is not a badly formed history value. It's a user > convenience variable. I'd make the test check that > such convenience variables work as intended. I did add such a test. > Otherwise looked fine. Thanks again. Committed.