From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16337 invoked by alias); 27 Feb 2011 01:38:11 -0000 Received: (qmail 16329 invoked by uid 22791); 27 Feb 2011 01:38:10 -0000 X-SWARE-Spam-Status: No, hits=-4.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,TW_RG,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 27 Feb 2011 01:38:06 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 4C67813028 for ; Sat, 26 Feb 2011 17:38:05 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost3.vmware.com (Postfix) with ESMTP id 42336CD976 for ; Sat, 26 Feb 2011 17:38:05 -0800 (PST) Message-ID: <4D69AAFC.6030607@vmware.com> Date: Sun, 27 Feb 2011 01:56:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: "gdb-patches@sourceware.org" Subject: [rfa] add_symbol_file_command, avoid memory leak. Content-Type: multipart/mixed; boundary="------------040404000007040407030009" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00823.txt.bz2 This is a multi-part message in MIME format. --------------040404000007040407030009 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 114 This looks straightforward, but I'd appreciate review. I don't really understand why sect_opts never gets freed? --------------040404000007040407030009 Content-Type: text/plain; name="symfile.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="symfile.txt" Content-length: 938 2011-02-26 Michael Snyder * symfile.c (add_symbol_file_command): Avoid memory leak. Index: symfile.c =================================================================== RCS file: /cvs/src/src/gdb/symfile.c,v retrieving revision 1.307 diff -u -p -u -p -r1.307 symfile.c --- symfile.c 26 Feb 2011 02:07:09 -0000 1.307 +++ symfile.c 27 Feb 2011 01:35:32 -0000 @@ -2169,15 +2169,15 @@ add_symbol_file_command (char *args, int size_t num_sect_opts = 0; struct cleanup *my_cleanups = make_cleanup (null_cleanup, NULL); + if (args == NULL) + error (_("add-symbol-file takes a file name and an address")); + num_sect_opts = 16; sect_opts = (struct sect_opt *) xmalloc (num_sect_opts * sizeof (struct sect_opt)); dont_repeat (); - if (args == NULL) - error (_("add-symbol-file takes a file name and an address")); - argv = gdb_buildargv (args); make_cleanup_freeargv (argv); --------------040404000007040407030009--