Re: [try 2nd 2/8] Rename copy_* functions to arm_copy_*

Ulrich Weigand
2011-04-06T20:51:32Z

Yao Qi wrote:

> The copy functions for arm and thumb instructions should be different.
> So some copy_* functions are renamed to arm_copy_* functions. In each
> copy functions, there are some arm-thumb-independent part, such as
> install cleanup helper, store register, etc. This part is moved to
> install_* functions.

The interface between the copy_ routines and the install_ routines
seems a bit odd in some cases: mostly, values are just passed as
arguments, but in some cases, they are passed via displaced_step_closure
fields.

I'd prefer if this were handled in a regular manner: the copy_
routines parse the insn text, extract all required information
and pass it all as arguments to the install_ routine. The
install_ routine then stores all information that is needed
by the cleanup_ routine into the displaced_step_closure struct.

Otherwise, the split seems OK to me.

Bye,
Ulrich

--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com