From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6699 invoked by alias); 22 Feb 2011 18:50:13 -0000 Received: (qmail 6690 invoked by uid 22791); 22 Feb 2011 18:50:13 -0000 X-SWARE-Spam-Status: No, hits=-4.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Feb 2011 18:50:08 +0000 Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id BCE461415E; Tue, 22 Feb 2011 10:50:07 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost4.vmware.com (Postfix) with ESMTP id B0264C9BCC; Tue, 22 Feb 2011 10:50:07 -0800 (PST) Message-ID: <4D64055F.2050803@vmware.com> Date: Tue, 22 Feb 2011 18:55:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: Pedro Alves CC: "gdb-patches@sourceware.org" Subject: Re: [commit] fix for "info threads" printing multiple headers References: <4D62F7D6.8040705@vmware.com> <201102220851.20252.pedro@codesourcery.com> <4D63FF97.7070903@vmware.com> <201102221837.24204.pedro@codesourcery.com> In-Reply-To: <201102221837.24204.pedro@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00620.txt.bz2 Pedro Alves wrote: > On Tuesday 22 February 2011 18:25:27, Michael Snyder wrote: >> Pedro Alves wrote: >> >>> Examples of not handling the special zero: >>> >>> (gdb) info threads a 1 >>> Id Target Id Frame >>> * 1 Thread 0x7ffff7fd6700 (LWP 13769) "threads" 0x00007ffff7bc7285 in pthread_join () from /lib/libpthread.so.0 >>> (gdb) >>> >>> (gdb) info threads a-1 >>> No threads match 'a-1'. >>> >>> (gdb) info threads a -1 >>> Id Target Id Frame >>> * 1 Thread 0x7ffff7fd6700 (LWP 13769) "threads" 0x00007ffff7bc7285 in pthread_join () from /lib/libpthread.so.0 >>> (gdb) >>> >>> The last one only "works" by accident due to the extra space. >> >> OK, test for zero added, how's this? > > Looks good. Committing. > I was hoping for turning the above into testcases, > making sure they fail. Can I trick you into > doing it? "No" is fine. :-) > Consider it done. ;-)