From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32766 invoked by alias); 22 Feb 2011 18:36:38 -0000 Received: (qmail 32756 invoked by uid 22791); 22 Feb 2011 18:36:37 -0000 X-SWARE-Spam-Status: No, hits=-4.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Feb 2011 18:36:28 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 655113F00A; Tue, 22 Feb 2011 10:36:27 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost3.vmware.com (Postfix) with ESMTP id 59858CD976; Tue, 22 Feb 2011 10:36:27 -0800 (PST) Message-ID: <4D64022A.9090405@vmware.com> Date: Tue, 22 Feb 2011 18:37:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: Tom Tromey CC: Pedro Alves , "gdb-patches@sourceware.org" Subject: Re: [commit] fix for "info threads" printing multiple headers References: <4D62F7D6.8040705@vmware.com> <201102220851.20252.pedro@codesourcery.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00614.txt.bz2 Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> Thanks! A few comments below. If you don't want to > Pedro> fix these, I'll try to find a bit later on myself. > > Pedro> - get_number_or_range mantains an internal state machine > Pedro> using static variables. I think that as long as you > Pedro> always pass in the same list string, and the list spec > Pedro> string is correctly formed, you're not hitting stale > Pedro> state inside get_number_or_range. It'd be nicer > Pedro> if get_number_or_range (or a variant which get_number_or_range > Pedro> would then be implemented on top of) took an additional > Pedro> struct pointer that pointed to a struct that held > Pedro> all the currently static state. > > I almost did this when moving stuff to cli-utils, but decided against it > on the basis of least change. > > If Michael doesn't want to implement this, I'd be happy to. > Just let me know. Seems like it would only be useful if the function had to be thread safe.