On 02/18/2011 04:24 PM, Jan Kratochvil wrote:

Jan,
Thanks for the quick review.

> There should be a wrapper:
> 
> #ifndef COMMON_LINUX_COMMON_H
> #define COMMON_LINUX_COMMON_H
> #endif /* COMMON_LINUX_COMMON_H */
> 

OK.  Done.

>> >  #include "gdb_proc_service.h"
>> > +#include "linux-common.h"
> If you moved the definitions out of linux-low.c it is enough
> to #include "linux-common.h" also just in linux-low.c.
> 

Oh, yes.  Fixed.

> If you moved the definitions out of linux-nat.c it is enough
> to #include "linux-common.h" also just in linux-nat.c.

Fixed as well.

-- 
Yao (齐尧)