Re: [common] Merge duplicated macros in linux-nat.c and linux-low.c

Yao Qi
2011-02-18T16:58:31Z

On 02/18/2011 11:46 PM, Pedro Alves wrote:
> Let's name the files according to their contents instead.
> Let's take the opportunity to split independent things
> into separate files if it makes sense to factor them out.
>

Yes, I agree. There have been some files named *-common in my local
gdb/common/ dir. :) They look odd on name.

> E.g., x86 watchpoint related macros -> x86-watch.h
> or x86-nat-watch.h or i386-watchpoint.h, or something
> like that, not x86-common.h.
>
> E.g., linux ptrace related macros and definition
> -> linux-ptrace.h or something like that.
>

Looks good to me. I'll name my files in this way.

--
Yao (é½å°§)