From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-78376-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 9374 invoked by alias); 17 Feb 2011 22:31:52 -0000
Received: (qmail 9366 invoked by uid 22791); 17 Feb 2011 22:31:52 -0000
X-SWARE-Spam-Status: No, hits=-5.8 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 17 Feb 2011 22:31:47 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p1HMVkMs030355	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Thu, 17 Feb 2011 17:31:46 -0500
Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p1HMVia0021139	(version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO)	for <gdb-patches@sourceware.org>; Thu, 17 Feb 2011 17:31:45 -0500
Message-ID: <4D5DA1D0.9060701@redhat.com>
Date: Fri, 18 Feb 2011 03:24:00 -0000
From: Keith Seitz <keiths@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc13 Lightning/1.0b3pre Thunderbird/3.1.7
MIME-Version: 1.0
To: gdb-patches@sourceware.org
Subject: Re: [patch 0/3] Re: [RFA] c++/11734 revisited (and c++/12273)
References: <4D002672.5090504@redhat.com> <m3oc8u1uzs.fsf@fleche.redhat.com> <4D07CD68.5000700@redhat.com> <20110206224548.GA5000@host1.dyn.jankratochvil.net> <4D545C68.3010102@redhat.com> <4D5D652B.9070200@redhat.com>
In-Reply-To: <4D5D652B.9070200@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-02/txt/msg00443.txt.bz2

And of course, no sooner do I submit this, than I see I forgot something...

On 02/17/2011 10:12 AM, Keith Seitz wrote:
> PR c++/11734
> * gdb.cp/ovsrch.exp: New test.

I have changed this to use prepare_for_testing:

@@ -500,21 +500,10 @@
  +
  +set srcfiles {}
  +for {set i 1} {$i < 5} {incr i} {
-+    lappend srcfiles [file join $srcdir $subdir $testfile$i.cc]
-+}
-+if  {[gdb_compile $srcfiles $binfile executable {debug c++}] != "" } {
-+     untested $testfile.exp
-+     return -1
++    lappend srcfiles $testfile$i.cc
  +}
  +
-+if {[get_compiler_info $binfile "c++"]} {
-+    return -1
-+}
-+
-+gdb_exit
-+gdb_start
-+gdb_reinitialize_dir $srcdir/$subdir
-+gdb_load $binfile
++prepare_for_testing $testfile $testfile $srcfiles {c++ debug}
  +
  +if {![runto_main]} {
  +    perror "couldn't run to breakpoint"

Keith