From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24472 invoked by alias); 17 Feb 2011 19:09:38 -0000 Received: (qmail 24464 invoked by uid 22791); 17 Feb 2011 19:09:37 -0000 X-SWARE-Spam-Status: No, hits=-4.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 17 Feb 2011 19:09:31 +0000 Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 0EBC310008; Thu, 17 Feb 2011 11:09:30 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost2.vmware.com (Postfix) with ESMTP id E38FF8ED24; Thu, 17 Feb 2011 11:09:29 -0800 (PST) Message-ID: <4D5D7269.4010903@vmware.com> Date: Thu, 17 Feb 2011 19:12:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: Jan Kratochvil CC: Pedro Alves , "gdb-patches@sourceware.org" , Tom Tromey Subject: Re: [RFC] info threads takes an argument References: <4D54964A.2070401@vmware.com> <4D5AEDA7.1000405@vmware.com> <201102161148.36948.pedro@codesourcery.com> <4D5C16D9.9030204@vmware.com> <20110217165333.GA29274@host1.dyn.jankratochvil.net> In-Reply-To: <20110217165333.GA29274@host1.dyn.jankratochvil.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00432.txt.bz2 Jan Kratochvil wrote: > On Wed, 16 Feb 2011 19:26:33 +0100, Michael Snyder wrote: >> Pedro Alves wrote: >>> Anyway, the reason I'm replying is that I noticed a couple >>> of new FAILs in this test, and looking at the log, I noticed >>> another issue: >> Urk. I did half my work on the 7.2 branch, where it doesn't do this. >> Let me fix it. > > I also see the failure: > > info threads 2 4 6 > Id Target Id Frame > 2 Thread 0x7ffff759e700 (LWP 24773) "threadname_2" 0x00007ffff7678213 in select () at ../sysdeps/unix/syscall-template.S:82 > Id Target Id Frame > 4 Thread 0x7ffff659c700 (LWP 24775) "threadname_4" 0x00007ffff7678213 in select () at ../sysdeps/unix/syscall-template.S:82 > Id Target Id Frame > 6 Thread 0x7ffff559a700 (LWP 24777) "threadname_6" __lll_lock_wait () at ../nptl/sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:136 > (gdb) FAIL: gdb.threads/thread-find.exp: info threads 2 4 6 > > -re ". 6 .*\"threadname_6.*\" \[\r\n\]*" { > set see6 1 > exp_continue > } > -re ". 5 .*\"threadname_5.*\" \[\r\n\]*" { > set see5 1 > exp_continue > } > > This is racy, * of the regexp is greedy by default and there can be multiple > threadnames available during a single read/match, one match can swallow > multiple entries. There should be some \[^\r\n\]* instead of any .* during > such unanchored matching. > > One may also rather catch the whole output and regex-match by hand the caught > output afterwards. I am not seeing these failures, even on the trunk. Would you guys please email me your gdb.log files for this test? Thanks, Michael