From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2302 invoked by alias); 17 Feb 2011 06:24:53 -0000 Received: (qmail 2294 invoked by uid 22791); 17 Feb 2011 06:24:52 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 17 Feb 2011 06:24:48 +0000 Received: (qmail 19552 invoked from network); 17 Feb 2011 06:24:46 -0000 Received: from unknown (HELO ?0.0.0.0?) (yao@127.0.0.2) by mail.codesourcery.com with ESMTPA; 17 Feb 2011 06:24:46 -0000 Message-ID: <4D5CBF2D.9020101@codesourcery.com> Date: Thu, 17 Feb 2011 06:36:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101208 Lightning/1.0b2 Thunderbird/3.1.7 MIME-Version: 1.0 To: Mark Kettenis CC: gdb-patches@sourceware.org Subject: Re: [patch] Move common macros to i386-common.h References: <4D57AB12.1050708@codesourcery.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00408.txt.bz2 On 02/13/2011 09:40 PM, Mark Kettenis wrote: > I'm just back from a 3+-week holiday. I'm not buying into the "share more > stuff between gdb and gdbserver" mantra yet. Please hold off on this > until > I've gotten caught up with my mail and had a chance to think about all this. > OK, no problem. IMO, it is beneficial to source code maintenance. w.r.t this specific patch, its "potential benefit" is that, some duplicated functions (i386_length_and_rw_bits, and i386_{insert|remove}_aligned_watchpoint) in i386-nat.c and gdbserver/i386-low.c can be merged together. Please take this into account. -- Yao (齐尧)