Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@vmware.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: Tom Tromey <tromey@redhat.com>,
	 "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [rfa] clean up output of "info set" command.
Date: Sat, 12 Feb 2011 00:08:00 -0000	[thread overview]
Message-ID: <4D55CF67.9070003@vmware.com> (raw)
In-Reply-To: <4D55CDBE.4080801@vmware.com>

Michael Snyder wrote:
> Pedro Alves wrote:
>> On Friday 11 February 2011 21:17:08, Tom Tromey wrote:
>>>>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:
>>> Pedro> Isn't there a property of the command we could check
>>> Pedro> instead of hardcoding specific command names?
>>>
>>> Michael> I'm open to suggestions.  The only property I can think of is that
>>> Michael> there is no corresponding entry in "setlist".  I could search
>>> Michael> setlist every time...
>>>
>>> You could stick a new flag on the command object.
>> Yeah.  You may even be able to set the flag from within
>> the add_setshow_... functions and friends.  The flag could
>> mean "this show command shows something that is settable
>> in some way" (or the reverse).
>>
>>> Or there is cmd_cfunc_eq, which is used for a similar purpose in some
>>> places.  I don't think this is super, but OTOH it isn't any worse than
>>> existing code.
>> I think we shouldn't allow ourselves to broadcast bad design
>> when it's easy not to.  The function Michael touched is within
>> gdb/cli/cli-setshow.c.  I'd prefer to keep this and the other
>> core command files clean of specific knowledge of 
>> any specific commands their clients register.
>>
>> I notice that "info set" is basically an alias of "show".
>> Does the change make sense in the context of "show",
>> or should "show" keep showing everything showable under
>> the show command?  "show foo|bar|..."
>>
> 
> They're synonyms.  But I still don't think that "show copying"
> is at all useful when presented in the middle of dozens of other
> show commands.

More specifically, "info set" is a synonym for "show" with no arguments.
However "info set" does not accept any arguments itself.  It's really a
pretty useless command, when you think about it.  I would have proposed
deleting it, but that would require modifying help.exp and default.exp,
and still wouldn't help the case of "show" with no arguments.



  reply	other threads:[~2011-02-12  0:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-11 20:20 Michael Snyder
2011-02-11 20:42 ` Pedro Alves
2011-02-11 20:53   ` Michael Snyder
2011-02-11 21:17     ` Tom Tromey
2011-02-11 23:33       ` Pedro Alves
2011-02-12  0:01         ` Michael Snyder
2011-02-12  0:08           ` Michael Snyder [this message]
2011-02-12  1:30         ` Michael Snyder
2011-02-12  7:55           ` Eli Zaretskii
2011-02-15  2:03             ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D55CF67.9070003@vmware.com \
    --to=msnyder@vmware.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox