From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-78123-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 32478 invoked by alias); 9 Feb 2011 18:44:07 -0000
Received: (qmail 32469 invoked by uid 22791); 9 Feb 2011 18:44:06 -0000
X-SWARE-Spam-Status: No, hits=-4.8 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 09 Feb 2011 18:44:01 +0000
Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167])	by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 62A1329009;	Wed,  9 Feb 2011 10:44:00 -0800 (PST)
Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138])	by mailhost2.vmware.com (Postfix) with ESMTP id 4EF7A8ED05;	Wed,  9 Feb 2011 10:44:00 -0800 (PST)
Message-ID: <4D52E06F.1080603@vmware.com>
Date: Wed, 09 Feb 2011 18:44:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 2.0.0.24 (X11/20101201)
MIME-Version: 1.0
To: "H.J. Lu" <hjl.tools@gmail.com>
CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA] fix for intel disassembly, truncated BFD_VMA
References: <4D52DEAC.1020607@vmware.com> <AANLkTinLHNp8Yck+Gy+P1HO1BZKOzs2JDhWuFpweh8DA@mail.gmail.com>
In-Reply-To: <AANLkTinLHNp8Yck+Gy+P1HO1BZKOzs2JDhWuFpweh8DA@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-02/txt/msg00190.txt.bz2

H.J. Lu wrote:
> On Wed, Feb 9, 2011 at 10:36 AM, Michael Snyder <msnyder@vmware.com> wrote:
>> This expression needed parentheses.  Without them, it was truncating the
>> target address of jumps and calls from BFD_VMA to 32-bits.
>>
>> Disassembly at high addresses is vastly improved.
>>
>>
>> 2011-02-09  Michael Snyder  <msnyder@vmware.com>
>>
>>        * i386-dis.c (OP_J): Parenthesize expression to prevent
>>        truncated addresses.
>>        (print_insn): Fix indentation off-by-one.
>>
>> Index: i386-dis.c
>> ===================================================================
>> RCS file: /cvs/src/src/opcodes/i386-dis.c,v
>> retrieving revision 1.257
>> diff -u -p -u -p -r1.257 i386-dis.c
>> --- i386-dis.c  18 Jan 2011 17:08:13 -0000      1.257
>> +++ i386-dis.c  9 Feb 2011 18:28:02 -0000
>> @@ -1,6 +1,6 @@
>>  /* Print i386 instructions for GDB, the GNU debugger.
>>    Copyright 1988, 1989, 1991, 1993, 1994, 1995, 1996, 1997, 1998, 1999,
>> -   2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010
>> +   2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011
>>    Free Software Foundation, Inc.
>>
>>    This file is part of the GNU opcodes library.
>> @@ -11702,9 +11702,9 @@ print_insn (bfd_vma pc, disassemble_info
>>       modrm.rm = *codep & 7;
>>     }
>>
>> -   need_vex = 0;
>> -   need_vex_reg = 0;
>> -   vex_w_done = 0;
>> +  need_vex = 0;
>> +  need_vex_reg = 0;
>> +  vex_w_done = 0;
>>
>>   if (dp->name == NULL && dp->op[0].bytemode == FLOATCODE)
>>     {
>> @@ -13817,7 +13817,7 @@ OP_J (int bytemode, int sizeflag)
>>       oappend (INTERNAL_DISASSEMBLER_ERROR);
>>       return;
>>     }
>> -  disp = ((start_pc + codep - start_codep + disp) & mask) | segment;
>> +  disp = ((start_pc + (codep - start_codep) + disp) & mask) | segment;
>>   set_op (disp, 0);
>>   print_operand_value (scratchbuf, 1, disp);
>>   oappend (scratchbuf);
>>
>>
> 
> OK.

Thanks, committed.