From: Vladimir Simonov <sv@sw.ru>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: gdb: Incorrect stack unwinding if compressed debug info is used
Date: Fri, 04 Feb 2011 18:43:00 -0000 [thread overview]
Message-ID: <4D4C4576.2020709@sw.ru> (raw)
In-Reply-To: <m3mxmb8z0c.fsf@fleche.redhat.com>
On 02/04/2011 08:56 PM, Tom Tromey wrote:
>
> So, I came up with the appended. Let me know what you think. If you
> could try it, that would be helpful.
>
This one works fine on my test also.
The only I can mention - the name
dwarf2_section_size a bit misleading, it hides
the fact that it will read section if it is not done.
May be just change dwarf2_read_section to return
size?
Also I'm not sure that call functions inside "if"
are encouraged in gdb coding style. I mean
+ if (header->abbrev_offset
+ >= dwarf2_section_size (dwarf2_per_objfile->objfile,
+ &dwarf2_per_objfile->abbrev))
etc.
Regards
Vladimir
next prev parent reply other threads:[~2011-02-04 18:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1296238472.3009.ezmlm@sourceware.org>
2011-01-31 16:57 ` Vladimir Simonov
2011-02-02 19:55 ` Paul Pluzhnikov
2011-02-03 16:51 ` Vladimir Simonov
2011-02-04 16:35 ` Tom Tromey
2011-02-04 16:34 ` Tom Tromey
2011-02-04 17:47 ` Vladimir Simonov
2011-02-04 17:56 ` Tom Tromey
2011-02-04 18:43 ` Vladimir Simonov [this message]
2011-02-04 20:31 ` Tom Tromey
2011-02-05 13:53 ` Vladimir Simonov
2011-02-07 15:00 ` Tom Tromey
2011-02-01 7:34 ` gdb: Incorrect stack unwinding if debug info is compressed Vladimir Simonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D4C4576.2020709@sw.ru \
--to=sv@sw.ru \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox