From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15434 invoked by alias); 31 Jan 2011 00:31:54 -0000 Received: (qmail 15421 invoked by uid 22791); 31 Jan 2011 00:31:53 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 31 Jan 2011 00:31:49 +0000 Received: (qmail 30300 invoked from network); 31 Jan 2011 00:31:47 -0000 Received: from unknown (HELO ?192.168.0.101?) (yao@127.0.0.2) by mail.codesourcery.com with ESMTPA; 31 Jan 2011 00:31:47 -0000 Message-ID: <4D4602EE.10001@codesourcery.com> Date: Mon, 31 Jan 2011 02:01:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101208 Thunderbird/3.1.7 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [rfa/rfc] Build libcommon.a for gdb and gdbserver References: <4D30E23F.3080103@codesourcery.com> <4D34C9DE.3040603@codesourcery.com> <4D375F44.70504@codesourcery.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00570.txt.bz2 On 01/28/2011 10:53 PM, Tom Tromey wrote: > Yao> 4 Building libcommon.a for gdb and gdbserver respectively. > > This seems to mean that we must build libcommon twice. I don't > understand that -- what is the benefit, versus having a single library? The benefit is that we have single source (in common/) rather than two. > Yao> diff --git a/gdb/Makefile.in b/gdb/Makefile.in > [...] > Yao> +$(LIBCOMMON): $(LIBCOMMON_DIR)/Makefile > Yao> + @$(MAKE) $(FLAGS_TO_PASS) DO=all DODIRS=common subdir_do > Yao> + > Yao> +configure-common: > Yao> + @: $(MAKE); $(unstage) > Yao> + @r=`${PWD_COMMAND}`; export r; \ > Yao> + s=`cd $(srcdir); ${PWD_COMMAND}`; export s; \ > > I believe gdb/configure will take care of this, because `common' is now > in AC_CONFIG_SUBDIRS. This bit is useful that common/ can be configured during gdb `make'. -- Yao (齐尧)